Update WebAPITokenManager to use token generators

Review Request #12419 — Created June 28, 2022 and submitted — Latest diff uploaded

Information

Djblets
release-3.x

Reviewers

Currently, token generation is baked into
djblets.webapi.managers.WebAPITokenManager. With our move to API Tokens v2,
we don't want token generation to be tightly coupled with Web API tokens. We
want tokens to be usable outside of just the API.

This change moves token generation out of WebAPITokenManager by making use of
token generators instead of directly generating tokens in WebAPITokenManager.
To do this we add two new parameters to WebAPITokenManager,
token_generator_id to decide what token generator to use and token_info to
pass along information needed for token generation to the token generator.

  • Updated WebAPITokenManager's unit tests to account for the use
    of token generators.
  • Ran all unit tests in djblets.webapi.tests with success.

Diff Revision 2

This is not the most recent revision of the diff. The latest diff is revision 7. See what's changed.

orig
1
2
3
4
5
6
7

Commits

First Last Summary ID Author
Update WebAPITokenManager to use Token Generators
6fe60bdab5c0235031d62e7a701f672cf524a7d9 Michelle Aubin
djblets/webapi/managers.py
djblets/webapi/tests/test_api_token.py
Loading...