Docstrings in this file should be "Testing ..."

Docstrings in this file should be "Testing ..."
You can also put the """ on the same line for this one.

I also mentioned it in the review for /r/12419, but we should instantiate the registry as an attribute of this module. You can use djblets.registries.importer.lazy_import_registry for this.

Typo: NotImeplementedError -> NotImplementedError.

There's an extra blank line here.

Typo: NotImeplementedError -> NotImplementedError.

There's not actually a **kwargs in the method signature.

Ship It!

For these tests, you can probably just put the data within the call. Helps keep the construction and parameters together.
Same below.

This can be consolidated:

token = (
    '_%s'
    % self.token_generator.create_token(...)[1:]
)

Typo: "charcter" -> "character"

This can be consolidated:

token = (
    '!%s'
    % self.token_generator.create_token(...)[1:]
)

This should have a doc comment.

Missing , optional

This method is missing a Returns.

This should make it clear what the return type should be if a determination could not be made.

Missing , optional

Let's say "legacy SHA1 tokens".

Let's say "legacy SHA1 tokens".

These should be in alphabetical order.

This method doesn't seem to ever return None.
However, it does raise an exception, which should be documented.

Blank line between these.

Localized text can't be formatted within the _(...). The % must be after.

No need for the outer parens.
Strings generally concatenate faster if joining via a format string, rather than +. So:

prefix = '%s%s%s' % (prefix, str(attempt), timezone.now().isoformat())

The in check requires a loop through charset for each character in token. Two things can be done to speed that up:

charset = set('0123456789abcdef')


Or, probably better, define a regex for what a SHA1 token can be: [0-9A-Fa-f]{40}
This would allow for a single optimized check.

For Registry, get() will raise an exception if the entry is not found.

We usually use snake_case for identifiers.

Doc comments are in the form of:

#: Summary
#:
#: ...


Same conventions as docstrings. These will get processed by Sphinx.

token_info probably shouldn't be optional here, should it?
If so, then the keys within must also be optional, and the function must check for them.

For Raises, the description must be indented.

Let's avoid the repeated self.CHARSET attribute lookup by pulling that out first.

Rather than re-assigning, you can do:

checksum = (
    self._base62_encode(...)
    .zfill(...)
)

This can be one statement.

Same note about token_info.
This will apply to all other classes too.

Same as with the SHA1 generator, we should avoid a search of [0-9a-f_] for every character in the hash.
We also want the cheapest check first, which would be the length check, since that's stored along with a string.
So I'd suggest a regex just for the hash part on the class-level, as simply ^_[0-9a-f]+$, and a check like:

return (len(token) == 255 and
        HASH_RE.match(token[len(token_type):]))

We access self.CHARSET many times, each involving an attribute lookup, which isn't free. Let's pull that out into a local variable.

Slightly faster as:

return ''.join(reversed(result))


This loops through result once. If using .reverse() instead, it loops twice, once to reverse the list, the second time to join items.

Blank line between these.

The formatting has to happen after _(...).

Just a few things left that I noticed this round. Almost there!

For these tests, let's feed in a hard-coded token. This gives us clear test data to work with, and avoids side effects from create_token changes or regressions.
This applies to the other generator tests as well.

Should be fully lowercase (snake_case is typically lowercase).

As this is a caller-time problem, we probably don't need to log anything. The exception will be fine.
Same with the other generator.

Small nit. We usually keep the % on the line with the argument.

If this is missing content, we probably just want to say "Nope, not valid for this generator" and return False.

Ship It!