Fix a bad render call when rendering change form pages.

 






 

 


  Review Request #12387
  —
  Created June 17, 2022 and submitted 

 




















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-5.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
In 2020, a change (0ebfa480a6) was made to ChangeFormPageView that

updated a render() call to renderPage(). This was done as part of a

series of fixes to page rendering, except that this particular update

was made to an AdminInlineGroupView. This function doesn't exist

there, so this failed. Apparently this has gone unnoticed, and wasn't

really that big of a breakage.


This change fixes that call, reverting it back to a render(). This

will be backported to 4.0.x.

 








  


 
 

  
Loaded the User change page. Verified it no longer errored out with

an invalid function call.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Fix a bad render call when rendering change form pages.
      
In 2020, a change (0ebfa480a6) was made to `ChangeFormPageView` that
updated a `render()` call to `renderPage()`. This was done as part of a
series of fixes to page rendering, except that this particular update
was made to an `AdminInlineGroupView`. This function doesn't exist
there, so this failed. Apparently this has gone unnoticed, and wasn't
really that big of a breakage.

This change fixes that call, reverting it back to a `render()`. This
will be backported to 4.0.x.

     


    		
    0d5315583bf4e8d94e6fcb37e737f7ae013ae5a3

   



  
 




 













 









 






  

 



















 




 




 














 





 

  

   




david




   

   







  

 



 

  


   

   

    
 
david



    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




chipx86




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed

   

  




  

   

    Change Summary:
   

   

    
Pushed to release-5.0.x (be6ee44)