Compute the Review Bot configuration page data in Python.

Review Request #12384 — Created June 17, 2022 and submitted — Latest diff uploaded

Information

ReviewBot
release-3.0.x

Reviewers

This updates ConfigureView to build most of the page state needed for
the configure page. This is less messy than doing it in the template,
more expandable, and allows us to reuse some state computation that
already existed on the Python side.

In the process, we get to remove the staticfiles template tag, which
doesn't exist on Django 3.2, and a bunch of tabs-vs-spaces issues have
been cleaned up.

Successfully configured Review Bot, changing broker URL settings and
seeing new broker status information. Also verified that the user shown
for Review Bot had all the correct information.

Diff Revision 1 (Latest)

Commits

First Last Summary ID Author
Compute the Review Bot configuration page data in Python.
This updates `ConfigureView` to build most of the page state needed for the configure page. This is less messy than doing it in the template and more expandable. In the process, we get to remove the `staticfiles` template tag, which doesn't exist on Django 3.2, and a bunch of tabs-vs-spaces issues have been cleaned up.
4791f41e567805de01d58c902944032825667c97 Christian Hammond
extension/reviewbotext/views.py
extension/reviewbotext/static/js/extensionConfig.es6.js
extension/reviewbotext/templates/reviewbot/configure.html
Loading...