Summary

Update LocalSiteManager unit tests to use the new assertQueries() method.

Review Request #12352 — Created June 10, 2022 and submitted June 16, 2022, 7:09 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Work is being done on LocalSite-related query optimizations. To help
ensure the changes have an effect on queries, we're now using the new
assertQueries() for all LocalSite unit tests that otherwise assert
non-0 query counts.

This lets us check the specifics of the queries, including details on
JOINs, annotations, fields that are queried, and more. Further
improvements to this functionality will be more easily verified through
unit test changes and in code reviews.

Testing Done

Unit tests pass.

Commits

Summary	ID
Update LocalSiteManager unit tests to use the new assertQueries() method. Work is being done on `LocalSite`-related query optimizations. To help ensure the changes have an effect on queries, we're now using the new `assertQueries()` for all `LocalSite` unit tests that otherwise assert non-0 query counts. This lets us check the specifics of the queries, including details on JOINs, annotations, fields that are queried, and more. Further improvements to this functionality will be more easily verified through unit test changes and in code reviews.	3623e9344730d140e3bc2b100172edf3ea5a58a4

Summary

Update LocalSiteManager unit tests to use the new assertQueries() method.

Work is being done on `LocalSite`-related query optimizations. To help ensure the changes have an effect on queries, we're now using the new `assertQueries()` for all `LocalSite` unit tests that otherwise assert non-0 query counts. This lets us check the specifics of the queries, including details on JOINs, annotations, fields that are queried, and more. Further improvements to this functionality will be more easily verified through unit test changes and in code reviews.

3623e9344730d140e3bc2b100172edf3ea5a58a4

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.0.x (e22a63d)