Update LocalSiteManager unit tests to use the new assertQueries() method.

 






 

 


  Review Request #12352
  —
  Created June 10, 2022 and submitted 

 




















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-5.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Work is being done on LocalSite-related query optimizations. To help

ensure the changes have an effect on queries, we're now using the new

assertQueries() for all LocalSite unit tests that otherwise assert

non-0 query counts.


This lets us check the specifics of the queries, including details on

JOINs, annotations, fields that are queried, and more. Further

improvements to this functionality will be more easily verified through

unit test changes and in code reviews.

 








  


 
 

  
Unit tests pass.

 







 









 





  

 


 
 

  



 

  
   


    Summary
    ID

   

  
  

   


    

     

      Update LocalSiteManager unit tests to use the new assertQueries() method.
      
Work is being done on `LocalSite`-related query optimizations. To help
ensure the changes have an effect on queries, we're now using the new
`assertQueries()` for all `LocalSite` unit tests that otherwise assert
non-0 query counts.

This lets us check the specifics of the queries, including details on
JOINs, annotations, fields that are queried, and more. Further
improvements to this functionality will be more easily verified through
unit test changes and in code reviews.

     


    		
    3623e9344730d140e3bc2b100172edf3ea5a58a4

   



  
 




 













 









 






  

 



















 




 




 














 





 

  

   




david




   

   







  

 



 

  


   

   

    
 
david


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




chipx86




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed

   

  




  

   

    Change Summary:
   

   

    
Pushed to release-5.0.x (e22a63d)