Summary

Move to the new PyMemcacheCache cache backend.

Review Request #12337 — Created June 3, 2022 and submitted June 13, 2022, 1:55 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The old python-memcached library is unmaintained, and as a result,
Django has deprecated their MemcachedCache backend. This change
updates our dependency to pymemcache and changes over to use the new
PyMemcacheCache backend.

Testing Done

Ran unit tests.

Commits

Summary	ID
Move to the new PyMemcacheCache cache backend. The old `python-memcached` library is unmaintained, and as a result, Django has deprecated their `MemcachedCache` backend. This change updates our dependency to `pymemcache` and changes over to use the new `PyMemcacheCache` backend. Testing Done: Ran unit tests.	14beced772915da427753ea99184214447e4a494

Issues

Description	From	Last Updated
should we mention that this change was made in Reviewboard 5.0 (similar to some other comments in this file)	maubin	June 7, 2022, 4:06 p.m.
This is kinda weirdly-formatted. Maybe a good opportunity to put this into a constant and use it in the places …	chipx86	June 8, 2022, 8:47 a.m.

flake8 passed.

JSHint passed.

reviewboard/cmdline/rbsite.py (Diff revision 1)

The issue has been resolved. Show all issues

should we mention that this change was made in Reviewboard 5.0 (similar to some other comments in this file)

Change Summary:

Include the version of Review Board where we're making the change in comments.

Commits:

	Summary	ID
	Move to the new PyMemcacheCache cache backend. The old `python-memcached` library is unmaintained, and as a result, Django has deprecated their `MemcachedCache` backend. This change updates our dependency to `pymemcache` and changes over to use the new `PyMemcacheCache` backend. Testing Done: Ran unit tests.	e10afe79cd43fbef72d7c07769421173d9d2a7b3
	Move to the new PyMemcacheCache cache backend. The old `python-memcached` library is unmaintained, and as a result, Django has deprecated their `MemcachedCache` backend. This change updates our dependency to `pymemcache` and changes over to use the new `PyMemcacheCache` backend. Testing Done: Ran unit tests.	405850c02599e560482a2ab840b99d5d809fca58

Diff:

Revision 2 (+194 -46)

Show changes

	reviewboard/dependencies.py
	reviewboard/admin/forms/general_settings.py
	reviewboard/cmdline/rbsite.py
	reviewboard/cmdline/tests/test_rbsite.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/cmdline/rbsite.py (Diff revision 2)

The issue has been resolved. Show all issues

This is kinda weirdly-formatted. Maybe a good opportunity to put this into a constant and use it in the places referencing it?

Commits:

	Summary	ID
	Move to the new PyMemcacheCache cache backend. The old `python-memcached` library is unmaintained, and as a result, Django has deprecated their `MemcachedCache` backend. This change updates our dependency to `pymemcache` and changes over to use the new `PyMemcacheCache` backend. Testing Done: Ran unit tests.	405850c02599e560482a2ab840b99d5d809fca58
	Move to the new PyMemcacheCache cache backend. The old `python-memcached` library is unmaintained, and as a result, Django has deprecated their `MemcachedCache` backend. This change updates our dependency to `pymemcache` and changes over to use the new `PyMemcacheCache` backend. Testing Done: Ran unit tests.	14beced772915da427753ea99184214447e4a494

Diff:

Revision 3 (+194 -46)

Show changes

	reviewboard/dependencies.py
	reviewboard/admin/forms/general_settings.py
	reviewboard/cmdline/rbsite.py
	reviewboard/cmdline/tests/test_rbsite.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.0.x (f0ac005)