Summary

Add TestCase.create_many_review_requests().

Review Request #12326 — Created June 2, 2022 and submitted June 8, 2022, 3:02 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This is a unit test helper method that can batch-create many review
requests at the same time. This is much faster than calling
create_review_request() in a loop, and performs as many operations in
batches as possible.

Not all state or operations can be set in this mode. For example, review
requests can't be published, though they can be set to be public. If
specific review requests need to have operations performed, they can be
called separately once created.

When marking review requests public, this will also take care to set the
counters on any review groups, reviewers, or the owner, as appropriate.

Testing Done

Made use of this in some upcoming unit tests that need lots of review
requests, and are sensitive to the counter fields.

Commits

Summary	ID
Add TestCase.create_many_review_requests(). This is a unit test helper method that can batch-create many review requests at the same time. This is much faster than calling `create_review_request()` in a loop, and performs as many operations in batches as possible. Not all state or operations can be set in this mode. For example, review requests can't be published, though they can be set to be public. If specific review requests need to have operations performed, they can be called separately once created. When marking review requests public, this will also take care to set the counters on any review groups, reviewers, or the owner, as appropriate.	3df837a1d9305b2db9481ce0864fb4f326cca154

Summary

Add TestCase.create_many_review_requests().

This is a unit test helper method that can batch-create many review requests at the same time. This is much faster than calling `create_review_request()` in a loop, and performs as many operations in batches as possible. Not all state or operations can be set in this mode. For example, review requests can't be published, though they can be set to be public. If specific review requests need to have operations performed, they can be called separately once created. When marking review requests public, this will also take care to set the counters on any review groups, reviewers, or the owner, as appropriate.

3df837a1d9305b2db9481ce0864fb4f326cca154

Issues

Description	From	Last Updated
F841 local variable 'local_id' is assigned to but never used	reviewbot	June 2, 2022, 1:47 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/testing/testcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F841 local variable 'local_id' is assigned to but never used
```

Change Summary:

Fixed setting local_id.

Commits:

	Summary	ID
	Add TestCase.create_many_review_requests(). This is a unit test helper method that can batch-create many review requests at the same time. This is much faster than calling `create_review_request()` in a loop, and performs as many operations in batches as possible. Not all state or operations can be set in this mode. For example, review requests can't be published, though they can be set to be public. If specific review requests need to have operations performed, they can be called separately once created. When marking review requests public, this will also take care to set the counters on any review groups, reviewers, or the owner, as appropriate.	34c67dfa1ac51577ee2aed86d013cf83c320c1bf
	Add TestCase.create_many_review_requests(). This is a unit test helper method that can batch-create many review requests at the same time. This is much faster than calling `create_review_request()` in a loop, and performs as many operations in batches as possible. Not all state or operations can be set in this mode. For example, review requests can't be published, though they can be set to be public. If specific review requests need to have operations performed, they can be called separately once created. When marking review requests public, this will also take care to set the counters on any review groups, reviewers, or the owner, as appropriate.	3df837a1d9305b2db9481ce0864fb4f326cca154

Diff:

Revision 2 (+530 -2)

Show changes

reviewboard/testing/testcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-5.0.x (ef126e5)