Create CommentManager to query for comments that are accessible by a given user

 






 

 


  Review Request #12309
  —
  Created May 30, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  maubin
 









 
 

  Review Board
 









 
 

  release-5.0.x
 









 
 

  
 









 
 

  
 









 
 

  12296
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Currently there is no efficient way to query for comments that are

accessible by a given user when using <AnyCommentClass>.objects. This change

creates a CommentManager and adds a method such that 

<AnyCommentClass>.objects.accessible(user) returns a queryset of comments that

are accessible by the given user.

 








  


 
 

  
    

  • Wrote unit tests for CommentManager and they pass.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9
10
11
12

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Create CommentManager to query for comments that are accessible
     
by a given user

    

   
  		
  39d45c91a107d1c52d3caaf0e793bbb752e182c4
  Michelle
 


 
  
 
 
  
   
    

     Create CommentManager to query for comments that are accessible
     
by a given user

    

   
  		
  7066c6c7465800ab790169ed2e7d76d768f67c74
  Michelle
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/reviews/managers.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/tests/test_comment_manager.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...