• 
      

    Fix applying patches in Mercurial.

    Review Request #12307 — Created May 30, 2022 and submitted

    Information

    RBTools
    release-3.x

    Reviewers

    A change in RBTools 3.1 resulted in a duplicate with_errors= argument
    passed to execute() in apply_patch(). MercurialClient._execute()
    was explicitly setting this and also allowing any arbitrary **kwargs
    to be passed in. This was missed due to lack of unit testing.

    This changes _execute() to take in with_errors as an argument with
    the default we want to set. It also adds unit testing for
    apply_patch() to ensure this code path does not regress.

    Unit tests pass.

    Tested by a customer that hit this issue.

    Summary ID
    Fix applying patches in Mercurial.
    A change in RBTools 3.1 resulted in a duplicate `with_errors=` argument passed to `execute()` in `apply_patch()`. `MercurialClient._execute()` was explicitly setting this and also allowing any arbitrary `**kwargs` to be passed in. This was missed due to lack of unit testing. This changes `_execute()` to take in `with_errors` as an argument with the default we want to set. It also adds unit testing for `apply_patch()` to ensure this code path does not regress.
    d85eee55643954bd902611488a1325e6163f4dde
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.x (0c16a55)