Summary

Fix some bugs in the legacy ClearCase backend.

Review Request #12306 — Created May 29, 2022 and submitted June 2, 2022, 9 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This fixes three issues I ran into when running tests against the legacy ClearCase
implementation. Specifically:

When running on Python 3, there were some unicode-vs-bytes bugs in the diff parsing.
If the diff had incorrectly formatted filenames (which didn't include the vobtag),
the diff parsing stage could infinite loop. I've added a fallback to ensure we don't
loop more than a limited number of times.
The path normalization for display was calling realpath on a relative path, which
(on Linux) would end up adding the CWD to the path. I've changed it so we first turn it
into an absolute path relative to the repo root, run realpath, and then make it
relative again.

Testing Done

Posted some changes using a dynamic view as the backend. Saw that I could post changes
without any errors, and that paths for files were displayed correctly.

Commits

Summary	ID
Fix some bugs in the legacy ClearCase backend. This fixes three issues I ran into when running tests against the legacy ClearCase implementation. Specifically: - When running on Python 3, there were some unicode-vs-bytes bugs in the diff parsing. - If the diff had incorrectly formatted filenames (which didn't include the vobtag), the diff parsing stage could infinite loop. I've added a fallback to ensure we don't loop more than a limited number of times. - The path normalization for display was calling `realpath` on a relative path, which (on Linux) would end up adding the CWD to the path. I've changed it so we first turn it into an absolute path relative to the repo root, run realpath, and then make it relative again. Testing Done: Posted some changes using a dynamic view as the backend. Saw that I could post changes without any errors, and that paths for files were displayed correctly.	6ba0e13903db593e654487e13a2c48823f1ae64c

Summary

Fix some bugs in the legacy ClearCase backend.

This fixes three issues I ran into when running tests against the legacy ClearCase implementation. Specifically: - When running on Python 3, there were some unicode-vs-bytes bugs in the diff parsing. - If the diff had incorrectly formatted filenames (which didn't include the vobtag), the diff parsing stage could infinite loop. I've added a fallback to ensure we don't loop more than a limited number of times. - The path normalization for display was calling `realpath` on a relative path, which (on Linux) would end up adding the CWD to the path. I've changed it so we first turn it into an absolute path relative to the repo root, run realpath, and then make it relative again. Testing Done: Posted some changes using a dynamic view as the backend. Saw that I could post changes without any errors, and that paths for files were displayed correctly.

6ba0e13903db593e654487e13a2c48823f1ae64c

Issues

Description	From	Last Updated
While here, can we improve the text here?	chipx86	June 1, 2022, 9:54 a.m.
Let's encode this once outside of the loop.	chipx86	June 1, 2022, 9:55 a.m.

flake8 passed.

JSHint passed.

reviewboard/scmtools/clearcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
While here, can we improve the text here?
```
reviewboard/scmtools/clearcase.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Let's encode this once outside of the loop.
```

Commits:

	Summary	ID
	Fix some bugs in the legacy ClearCase backend. This fixes three issues I ran into when running tests against the legacy ClearCase implementation. Specifically: - When running on Python 3, there were some unicode-vs-bytes bugs in the diff parsing. - If the diff had incorrectly formatted filenames (which didn't include the vobtag), the diff parsing stage could infinite loop. I've added a fallback to ensure we don't loop more than a limited number of times. - The path normalization for display was calling `realpath` on a relative path, which (on Linux) would end up adding the CWD to the path. I've changed it so we first turn it into an absolute path relative to the repo root, run realpath, and then make it relative again. Testing Done: Posted some changes using a dynamic view as the backend. Saw that I could post changes without any errors, and that paths for files were displayed correctly.	f75a22b9f38b7dae09c5c3748e42f352f664548a
	Fix some bugs in the legacy ClearCase backend. This fixes three issues I ran into when running tests against the legacy ClearCase implementation. Specifically: - When running on Python 3, there were some unicode-vs-bytes bugs in the diff parsing. - If the diff had incorrectly formatted filenames (which didn't include the vobtag), the diff parsing stage could infinite loop. I've added a fallback to ensure we don't loop more than a limited number of times. - The path normalization for display was calling `realpath` on a relative path, which (on Linux) would end up adding the CWD to the path. I've changed it so we first turn it into an absolute path relative to the repo root, run realpath, and then make it relative again. Testing Done: Posted some changes using a dynamic view as the backend. Saw that I could post changes without any errors, and that paths for files were displayed correctly.	6ba0e13903db593e654487e13a2c48823f1ae64c

Diff:

Revision 2 (+88 -96)

Show changes

reviewboard/scmtools/clearcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (f52ee07)