Add a method for returning reviews that are accessible by a given user to ReviewManager
Review Request #12302 — Created May 25, 2022 and submitted — Latest diff uploaded
Currently there is no efficient way to query for reviews that are
accessible by a given user when usingReviews.objects
. This change adds a
method toReviewManager
such thatReviews.objects.accessible(user)
returns a
queryset of reviews that are accessible by the given user.
- Created
test_review_manager.py
file and moved in theReviewManager
tests fromtest_review.py
. - Created tests for
Review.objects.accessible
and ran all tests in
test_review_manager.py
with success.
Changes between revision 4 and 5
orig
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
Commits
Files
AUTHORS |
---|
doc-requirements.txt |
---|
contrib/internal/devserver.py |
---|
docs/manual/_ext/webapidocs.py |
---|
docs/manual/admin/configuration/diffviewer-settings.rst |
---|
docs/manual/fixtures/initial_data.json |
---|
reviewboard/dependencies.py |
---|
reviewboard/settings.py |
---|
reviewboard/admin/form_widgets.py |
---|
reviewboard/admin/siteconfig.py |
---|
reviewboard/admin/forms/diff_settings.py |
---|
reviewboard/admin/tests/test_lexers_mapping_widget.py |
---|
reviewboard/datagrids/grids.py |
---|
reviewboard/diffviewer/chunk_generator.py |
---|
reviewboard/diffviewer/tests/test_raw_diff_chunk_generator.py |
---|
reviewboard/oauth/__init__.py |
---|
reviewboard/oauth/apps.py |
---|
reviewboard/oauth/signal_handlers.py |
---|
reviewboard/reviews/managers.py |
---|
reviewboard/reviews/templatetags/reviewtags.py |
---|
reviewboard/reviews/tests/test_comment_diff_fragments_view.py |
---|
reviewboard/reviews/tests/test_reviewtags.py |
---|
reviewboard/site/__init__.py |
---|
reviewboard/site/apps.py |
---|
reviewboard/site/models.py |
---|
reviewboard/site/signal_handlers.py |
---|