Add a method for returning reviews that are accessible by a given user to ReviewManager

 






 

 


  Review Request #12302
  —
  Created May 25, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  maubin
 









 
 

  Review Board
 









 
 

  release-5.0.x
 









 
 

  
 









 
 

  
 









 
 

  12297
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Currently there is no efficient way to query for reviews that are

accessible by a given user when using Reviews.objects. This change adds a 

method to ReviewManager such that Reviews.objects.accessible(user) returns a

queryset of reviews that are accessible by the given user.

 








  


 
 

  
    

  • Created test_review_manager.py file and moved in the ReviewManager
    
  tests from test_review.py.
    • 

  • Created tests for Review.objects.accessible and ran all tests in
    
test_review_manager.py with success.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 15 and 16



    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Add a method for returning reviews that are accessible by a given user
     
to ReviewManager

    

   
  		
  93750baa5155c41694610d9f781a85fc3d9b5e85
  Michelle
 


 
  
 
 
  
   
    

     Add a method for returning reviews that are accessible by a given user
     
to ReviewManager

    

   
  		
  20a345390429c346b00c0df85c3ae1b709a19a1a
  Michelle
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/dependencies.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/datagrids/tests.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/templatetags/difftags.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_difftags.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/hostingsvcs/managers.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/hostingsvcs/tests/test_hosting_service_account_manager.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/managers.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/registry.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/tests/test_registry.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/css/mixins/style.less
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/css/pages/reviews.less
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/css/ui/forms.less
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/css/ui/admin/widgets.less
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/css/ui/review-request/issue-summary-table.less
     
    

   
  

 










     

    

   

  

  

   
   Loading...