Summary

Defer constraints and indexes when creating models through the evolver.

Review Request #12282 — Created May 15, 2022 and submitted May 16, 2022, 2:15 p.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

release-2.x

Bugs

Depends On

Reviewers

Groups

django-evolution

People

Description

When generating SQL for new models, EvolveAppTask was lumping together
the SQL for the model creation and for any constraints/indexes. This
could be fine a lot of the time, but depending on the complexity of the
upgrade, that deferred SQL could fail.

A sample scenario would be an app creating a model that has a reference
to an existing model, but to a newer Primary Key type that would be (but
hasn't yet been) evolved on the target model.

We now separately track the model creation SQL and the deferred SQL. All
deferred SQL is executed once all evolutions and migrations have
concluded.

Testing Done

All unit tests pass for all databases.

Verified this fixed a messy upgrade issue with Review Board 4 -> 5.

Commits

Summary	ID
Defer constraints and indexes when creating models through the evolver. When generating SQL for new models, `EvolveAppTask` was lumping together the SQL for the model creation and for any constraints/indexes. This could be fine a lot of the time, but depending on the complexity of the upgrade, that deferred SQL could fail. A sample scenario would be an app creating a model that has a reference to an existing model, but to a newer Primary Key type that would be (but hasn't yet been) evolved on the target model. We now separately track the model creation SQL and the deferred SQL. All deferred SQL is executed once all evolutions and migrations have concluded.	fd87cf874ff4490953df00b46ee8a94b4cb7ad2e

Summary

Defer constraints and indexes when creating models through the evolver.

When generating SQL for new models, `EvolveAppTask` was lumping together the SQL for the model creation and for any constraints/indexes. This could be fine a lot of the time, but depending on the complexity of the upgrade, that deferred SQL could fail. A sample scenario would be an app creating a model that has a reference to an existing model, but to a newer Primary Key type that would be (but hasn't yet been) evolved on the target model. We now separately track the model creation SQL and the deferred SQL. All deferred SQL is executed once all evolutions and migrations have concluded.

fd87cf874ff4490953df00b46ee8a94b4cb7ad2e

flake8 passed.

JSHint passed.

Change Summary:

Fixed a unit test on MySQL.

Commits:

	Summary	ID
	Defer constraints and indexes when creating models through the evolver. When generating SQL for new models, `EvolveAppTask` was lumping together the SQL for the model creation and for any constraints/indexes. This could be fine a lot of the time, but depending on the complexity of the upgrade, that deferred SQL could fail. A sample scenario would be an app creating a model that has a reference to an existing model, but to a newer Primary Key type that would be (but hasn't yet been) evolved on the target model. We now separately track the model creation SQL and the deferred SQL. All deferred SQL is executed once all evolutions and migrations have concluded.	289ebda25cd102f68dde83efe38ae48b6497c7e4
	Defer constraints and indexes when creating models through the evolver. When generating SQL for new models, `EvolveAppTask` was lumping together the SQL for the model creation and for any constraints/indexes. This could be fine a lot of the time, but depending on the complexity of the upgrade, that deferred SQL could fail. A sample scenario would be an app creating a model that has a reference to an existing model, but to a newer Primary Key type that would be (but hasn't yet been) evolved on the target model. We now separately track the model creation SQL and the deferred SQL. All deferred SQL is executed once all evolutions and migrations have concluded.	fd87cf874ff4490953df00b46ee8a94b4cb7ad2e

Diff:

Revision 2 (+240 -52)

Show changes

	django_evolution/compat/db.py
	django_evolution/evolve/evolve_app_task.py
	django_evolution/tests/test_evolver.py
	django_evolution/tests/db/mysql.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.x (52c43f8)