Use registry get_defaults() to return built-in hosting services.

Review Request #12209 — Created March 24, 2022 and submitted — Latest diff uploaded

Information

Review Board
release-5.0.x

Reviewers

Entry points are fantastic, and they're a great way for us to allow
third parties to integrate their own plugins with Review Board.
Unfortunately, if there's a VersionConflict present in the install, no
entry points will load, even if things will otherwise work. The result
of this is that none of our built-in services will work properly.

This change moves our built-ins directly into the registry's
get_defaults() method, rather than using entry points. Any third-party
services will still be loaded from entry points afterwards.

Started with a fresh database and virtualenv. Saw that built-in services
were available in the "Add Repository" form.

Diff Revision 2 (Latest)

orig
1
2

Commits

First Last Summary ID Author
Use registry get_defaults() to return built-in hosting services.
Entry points are fantastic, and they're a great way for us to allow third parties to integrate their own plugins with Review Board. Unfortunately, if there's a VersionConflict present in the install, no entry points will load, even if things will otherwise work. The result of this is that none of our built-in services will work properly. This change moves our built-ins directly into the registry's `get_defaults()` method, rather than using entry points. Any third-party services will still be loaded from entry points afterwards. Testing Done: Started with a fresh database and virtualenv. Saw that built-in services were available in the "Add Repository" form.
597170903e6fbda892905bc6485d03846152d808 David Trowbridge
setup.py
reviewboard/hostingsvcs/assembla.py
reviewboard/hostingsvcs/beanstalk.py
reviewboard/hostingsvcs/bitbucket.py
reviewboard/hostingsvcs/bugzilla.py
reviewboard/hostingsvcs/codebasehq.py
reviewboard/hostingsvcs/fedorahosted.py
reviewboard/hostingsvcs/fogbugz.py
reviewboard/hostingsvcs/gerrit.py
reviewboard/hostingsvcs/github.py
reviewboard/hostingsvcs/gitlab.py
reviewboard/hostingsvcs/gitorious.py
reviewboard/hostingsvcs/googlecode.py
reviewboard/hostingsvcs/jira.py
reviewboard/hostingsvcs/kiln.py
reviewboard/hostingsvcs/rbgateway.py
reviewboard/hostingsvcs/redmine.py
reviewboard/hostingsvcs/service.py
reviewboard/hostingsvcs/sourceforge.py
reviewboard/hostingsvcs/splat.py
reviewboard/hostingsvcs/trac.py
reviewboard/hostingsvcs/unfuddle.py
reviewboard/hostingsvcs/versionone.py
Loading...