Use registry get_defaults() to return built-in hosting services.

 






 

 


  Review Request #12209
  —
  Created March 24, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-5.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Entry points are fantastic, and they're a great way for us to allow

third parties to integrate their own plugins with Review Board.

Unfortunately, if there's a VersionConflict present in the install, no

entry points will load, even if things will otherwise work. The result

of this is that none of our built-in services will work properly.


This change moves our built-ins directly into the registry's

get_defaults() method, rather than using entry points. Any third-party

services will still be loaded from entry points afterwards.

 








  


 
 

  
Started with a fresh database and virtualenv. Saw that built-in services

were available in the "Add Repository" form.

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Use registry get_defaults() to return built-in hosting services.
     
Entry points are fantastic, and they're a great way for us to allow
third parties to integrate their own plugins with Review Board.
Unfortunately, if there's a VersionConflict present in the install, no
entry points will load, even if things will otherwise work. The result
of this is that none of our built-in services will work properly.

This change moves our built-ins directly into the registry's
`get_defaults()` method, rather than using entry points. Any third-party
services will still be loaded from entry points afterwards.

Testing Done:
Started with a fresh database and virtualenv. Saw that built-in services
were available in the "Add Repository" form.

    

   
  		
  a2f260f99afaaa88c82938da04ca1dbbca21aac2
  David Trowbridge
 


 
  
 
 
  
   
    

     Use registry get_defaults() to return built-in hosting services.
     
Entry points are fantastic, and they're a great way for us to allow
third parties to integrate their own plugins with Review Board.
Unfortunately, if there's a VersionConflict present in the install, no
entry points will load, even if things will otherwise work. The result
of this is that none of our built-in services will work properly.

This change moves our built-ins directly into the registry's
`get_defaults()` method, rather than using entry points. Any third-party
services will still be loaded from entry points afterwards.

Testing Done:
Started with a fresh database and virtualenv. Saw that built-in services
were available in the "Add Repository" form.

    

   
  		
  597170903e6fbda892905bc6485d03846152d808
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/hostingsvcs/service.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...