Fix a bad variable access in rbt review edit.

 






 

 


  Review Request #12187
  —
  Created March 21, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  RBTools
 









 
 

  release-3.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
rbt review edit was attempting to access options.no_ship_it, which

doesn't exist and caused a crash. Both --ship-it and --no-ship-it

set options.ship_it.


This has been reworked to check just options.ship_it, and to check for

its presence using None rather than truthiness/falsiness.

 








  


 
 

  
Tested all rbt review commands and all options, verifying the results

on my test server.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix a bad variable access in rbt review edit.
     
`rbt review edit` was attempting to access `options.no_ship_it`, which
doesn't exist and caused a crash. Both `--ship-it` and `--no-ship-it`
set `options.ship_it`.

This has been reworked to check just `options.ship_it`, and to check for
its presence using `None` rather than truthiness/falsiness.

    

   
  		
  4712ad136b83f80fdcd843973fb5f7422fd95919
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbtools/commands/review.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...