Summary

Fix a bad variable access in rbt review edit.

Review Request #12187 — Created March 21, 2022 and submitted March 21, 2022, 10:20 p.m.

Information

Owner

chipx86

Repository

RBTools

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

rbt review edit was attempting to access options.no_ship_it, which
doesn't exist and caused a crash. Both --ship-it and --no-ship-it
set options.ship_it.

This has been reworked to check just options.ship_it, and to check for
its presence using None rather than truthiness/falsiness.

Testing Done

Tested all rbt review commands and all options, verifying the results
on my test server.

Commits

Summary	ID
Fix a bad variable access in rbt review edit. `rbt review edit` was attempting to access `options.no_ship_it`, which doesn't exist and caused a crash. Both `--ship-it` and `--no-ship-it` set `options.ship_it`. This has been reworked to check just `options.ship_it`, and to check for its presence using `None` rather than truthiness/falsiness.	4712ad136b83f80fdcd843973fb5f7422fd95919

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.x (7e7b3fc)