Fix JSON output when crashing, and fix help and version information.
Review Request #12163 — Created March 17, 2022 and submitted
When using
--json
, if the command raises an unexpected exception, we
end up showing an empty "success" payload. This is clearly not what we
want. This change insteads records an "Internal Error" with the
exception's error message, allowing tools to know that something went
wrong.The help string for
--json
has also been updated to include a trailing
period, matching other help strings. It also now includes anadded_in
version for the documentation, and theVersion Added
forJSONOutput
now correctly shows 3.0.
Tested
--json
with an exception raised, and saw the exception details.Saw the corrected help text.
Summary | ID |
---|---|
3c63c5fd513fc17f22e86f874fc26ac4efb9fbfa |
- Change Summary:
-
Updated to fix version information.
- Summary:
-
Fix JSON output when crashing, and fix the help string.Fix JSON output when crashing, and fix help and version information.
- Description:
-
When using
--json
, if the command raises an unexpected exception, weend up showing an empty "success" payload. This is clearly not what we want. This change insteads records an "Internal Error" with the exception's error message, allowing tools to know that something went wrong. The help string for
--json
has also been updated to include a trailing~ period, matching other help strings. ~ period, matching other help strings. It also now includes an added_in
+ version for the documentation, and the Version Added
forJSONOutput
+ now correctly shows 3.0. - Commits:
-
Summary ID f20793af1d946a1ca6004e4b7259692612f1024f 3c63c5fd513fc17f22e86f874fc26ac4efb9fbfa - Diff:
-
Revision 2 (+10 -4)