• 
      

    Add support for Review Bot workers in Docker.

    Review Request #12137 — Created March 11, 2022 and submitted

    Information

    ReviewBot
    release-3.0.x

    Reviewers

    This introduces a series of Docker images for running Review Bot
    workers. Since there are so many tools, and not all of them are needed
    for all deployments, Review Bot is split into a series of Docker images
    for workers, focused on:

    • Base support for tools without external dependencies
    • C analysis
    • Go analysis
    • Java analysis
    • JavaScript analysis
    • Python analysis
    • Ruby analysis
    • Rust analysis
    • shell script analysis
    • The multi-language FBInfer tool
    • The multi-language PMD tool

    There is no comprehensive "all" image, but it's likely not needed.
    In the upcoming documentation, we'll offer guidance on how to build
    custom Docker images that use the explicit tools people need.

    The images are currently built only for x86 architectures. ARM should
    mostly be supported by the tools, with the exception of FBInfer.

    Built all the images and launched them in a docker-compose.yaml.

    Successfully performed reviews with all tools.

    (There were issues with the RabbitMQ image crashing and restarting,
    but this seems to be a Docker on M1 issue).

    Summary ID
    Add support for Review Bot workers in Docker.
    This introduces a series of Docker images for running Review Bot workers. Since there are so many tools, and not all of them are needed for all deployments, Review Bot is split into a series of Docker images for workers, focused on: * Base support for tools without external dependencies * C analysis * Go analysis * Java analysis * JavaScript analysis * Python analysis * Ruby analysis * Rust analysis * shell script analysis * The multi-language FBInfer tool * The multi-language PMD tool There is no comprehensive "all" image, but it's likely not needed. In the upcoming documentation, we'll offer guidance on how to build custom Docker images that use the explicit tools people need. The images are currently built only for x86 architectures. ARM should mostly be supported by the tools, with the exception of FBInfer.
    5f9d9c23ff7b563e47a4677b04e17d13dd852c8b
    Description From Last Updated

    E402 module level import not at top of file

    reviewbotreviewbot

    E402 module level import not at top of file

    reviewbotreviewbot
    Checks run (1 failed, 1 succeeded)
    flake8 failed.
    JSHint passed.

    flake8

    chipx86
    Review request changed
    Change Summary:

    Removed a change meant for the docs update.

    Commits:
    Summary ID
    Add support for Review Bot workers in Docker.
    This introduces a series of Docker images for running Review Bot workers. Since there are so many tools, and not all of them are needed for all deployments, Review Bot is split into a series of Docker images for workers, focused on: * Base support for tools without external dependencies * C analysis * Go analysis * Java analysis * JavaScript analysis * Python analysis * Ruby analysis * Rust analysis * shell script analysis * The multi-language FBInfer tool * The multi-language PMD tool There is no comprehensive "all" image, but it's likely not needed. In the upcoming documentation, we'll offer guidance on how to build custom Docker images that use the explicit tools people need. The images are currently built only for x86 architectures. ARM should mostly be supported by the tools, with the exception of FBInfer.
    6365b10fc49cd849ecc4d23be7e1974a3bf61d4a
    Add support for Review Bot workers in Docker.
    This introduces a series of Docker images for running Review Bot workers. Since there are so many tools, and not all of them are needed for all deployments, Review Bot is split into a series of Docker images for workers, focused on: * Base support for tools without external dependencies * C analysis * Go analysis * Java analysis * JavaScript analysis * Python analysis * Ruby analysis * Rust analysis * shell script analysis * The multi-language FBInfer tool * The multi-language PMD tool There is no comprehensive "all" image, but it's likely not needed. In the upcoming documentation, we'll offer guidance on how to build custom Docker images that use the explicit tools people need. The images are currently built only for x86 architectures. ARM should mostly be supported by the tools, with the exception of FBInfer.
    5f9d9c23ff7b563e47a4677b04e17d13dd852c8b

    Checks run (1 failed, 1 succeeded)

    flake8 failed.
    JSHint passed.

    flake8

    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.0.x (163a830)