Add missing data parameter for MimetypeHandler.set_thumbnail.

 






 

 


  Review Request #12109
  —
  Created March 7, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-5.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
The abstract MimetypeHandler class defines a set_thumbnail method

which is always expected to be overridden by subclasses. Unfortunately

the method signature didn't match, which caused static analysis tools to

get mad. This change adds the missing data argument.

 








  


 
 

  
Saw SA error disappear after adding missing param.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Add missing data parameter for MimetypeHandler.set_thumbnail.
     
The abstract `MimetypeHandler` class defines a `set_thumbnail` method
which is always expected to be overridden by subclasses. Unfortunately
the method signature didn't match, which caused static analysis tools to
get mad. This change adds the missing `data` argument.

Testing Done:
Saw SA error disappear after adding missing param.

    

   
  		
  c32a5e0159c477a86a231c6510391df04c57120f
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/attachments/mimetypes.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...