Fix a crash when querying Review Bot worker status in error states.

Review Request #12093 — Created Feb. 28, 2022 and submitted — Latest diff uploaded

Information

ReviewBot
release-3.0.x

Reviewers

Review Bot expected that all workers would respond with a successful
state, and if that didn't occur, the extension would crash retrieving
status.

Now, the worker looks for error payloads and returns an error state if
any hosts reported an error or did not report a status.

Manually tested with a failed worker.

Unit tests pass.

Diff Revision 2 (Latest)

orig
1
2

Commits

First Last Summary ID Author
Fix a crash when querying Review Bot worker status in error states.
Review Bot expected that all workers would respond with a successful state, and if that didn't occur, the extension would crash retrieving status. Now, the worker looks for error payloads and returns an error state if any hosts reported an error or did not report a status.
066722d68725de1ae4df8935d98c6d95f16e8bde Christian Hammond
extension/reviewbotext/views.py
extension/reviewbotext/tests/test_worker_status_view.py
Loading...