Summary

Fix a crash when querying Review Bot worker status in error states.

Review Request #12093 — Created Feb. 28, 2022 and submitted March 2, 2022, 12:42 a.m.

Owner

Repository

ReviewBot

Branch

release-3.0.x

Bugs

Depends On

Groups

People

Description

Review Bot expected that all workers would respond with a successful
state, and if that didn't occur, the extension would crash retrieving
status.

Now, the worker looks for error payloads and returns an error state if
any hosts reported an error or did not report a status.

Testing Done

Manually tested with a failed worker.

Unit tests pass.

Commits

Summary	ID
Fix a crash when querying Review Bot worker status in error states. Review Bot expected that all workers would respond with a successful state, and if that didn't occur, the extension would crash retrieving status. Now, the worker looks for error payloads and returns an error state if any hosts reported an error or did not report a status.	066722d68725de1ae4df8935d98c6d95f16e8bde

Issues

Description	From	Last Updated
F401 'reviewbotext.views.WorkerStatusView' imported but unused	reviewbot	Feb. 28, 2022, 12:27 a.m.

flake8 failed.

JSHint passed.

extension/reviewbotext/tests/test_worker_status_view.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'reviewbotext.views.WorkerStatusView' imported but unused
```

Change Summary:

Removed an unused import.

Commits:

	Summary	ID
	Fix a crash when querying Review Bot worker status in error states. Review Bot expected that all workers would respond with a successful state, and if that didn't occur, the extension would crash retrieving status. Now, the worker looks for error payloads and returns an error state if any hosts reported an error or did not report a status.	66da7b4037bdaeb3e21ba1ec046529c9fe017cc4
	Fix a crash when querying Review Bot worker status in error states. Review Bot expected that all workers would respond with a successful state, and if that didn't occur, the extension would crash retrieving status. Now, the worker looks for error payloads and returns an error state if any hosts reported an error or did not report a status.	066722d68725de1ae4df8935d98c6d95f16e8bde

Diff:

Revision 2 (+548 -20)

	extension/reviewbotext/views.py
	extension/reviewbotext/tests/test_worker_status_view.py

flake8 passed.

JSHint passed.

Ship it!