Do some code housekeeping.

Review Request #12084 — Created Feb. 24, 2022 and discarded — Latest diff uploaded

Information

Review Board
release-5.0.x

Reviewers

This change does a whole bunch of small cleanups:

  • Fix up a bunch of issues with indentation, wrapping, and blank lines.
  • Remove a lot of dead code.
  • Always use cls as the bound variable for class methods.
  • Add in a few checks and assignments to prevent potentially unbound
    variable accesses in pathological cases.

Ran unit tests.

Diff Revision 1 (Latest)

Commits

First Last Summary ID Author
Do some code housekeeping.
This change does a whole bunch of small cleanups: - Fix up a bunch of issues with indentation, wrapping, and blank lines. - Remove a lot of dead code. - Always use `cls` as the bound variable for class methods. - Add in a few checks and assignments to prevent potentially unbound variable accesses in pathological cases. Testing Done: Ran unit tests.
0db34d73adfeb0c6a2f4e024965f07082dadacca David Trowbridge
This diff has been split across 3 pages: < 1 2 3 >
reviewboard/oauth/widgets.py
reviewboard/reviews/builtin_fields.py
reviewboard/reviews/views.py
reviewboard/reviews/models/status_update.py
reviewboard/reviews/templatetags/reviewtags.py
reviewboard/reviews/tests/test_actions.py
reviewboard/reviews/tests/test_forms.py
reviewboard/reviews/tests/test_new_review_request_view.py
reviewboard/scmtools/git.py
reviewboard/scmtools/hg.py
reviewboard/scmtools/svn/__init__.py
reviewboard/scmtools/svn/subvertpy.py
reviewboard/site/conditions.py
reviewboard/site/validation.py
reviewboard/webapi/models.py
reviewboard/webapi/resources/archived_review_request.py
reviewboard/webapi/resources/draft_diff.py
reviewboard/webapi/resources/extension.py
reviewboard/webapi/resources/muted_review_request.py
reviewboard/webapi/resources/review.py
This diff has been split across 3 pages: < 1 2 3 >
Loading...