Summary

Do some code housekeeping.

Review Request #12084 — Created Feb. 24, 2022 and discarded March 7, 2022, 4:19 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change does a whole bunch of small cleanups:

Fix up a bunch of issues with indentation, wrapping, and blank lines.
Remove a lot of dead code.
Always use cls as the bound variable for class methods.
Add in a few checks and assignments to prevent potentially unbound

  variable accesses in pathological cases.

Testing Done

Ran unit tests.

Commits

Summary	ID
Do some code housekeeping. This change does a whole bunch of small cleanups: - Fix up a bunch of issues with indentation, wrapping, and blank lines. - Remove a lot of dead code. - Always use `cls` as the bound variable for class methods. - Add in a few checks and assignments to prevent potentially unbound variable accesses in pathological cases. Testing Done: Ran unit tests.	0db34d73adfeb0c6a2f4e024965f07082dadacca

flake8 passed.

JSHint passed.

Status:: Discarded