Do some cleanup on exception handling.

 






 

 


  Review Request #12083
  —
  Created Feb. 24, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  release-5.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change fixes some mechanical issues with exception handling:


    

  • We had a few places that had bare except syntax. These have been
    
  updated to explicitly list exception types.
    • 

  • A number of places were assigning the exception to e but not using
    
  it.
    • 

  • In one place, we had two handlers for HostingServiceException, which
    
  meant that the second one was dead code.
    • 


 








  


 
 

  
Ran unit tests.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Do some cleanup on exception handling.
     
This change fixes some mechanical issues with exception handling:

- We had a few places that had bare `except` syntax. These have been
  updated to explicitly list exception types.
- A number of places were assigning the exception to `e` but not using
  it.
- In one place, we had two handlers for `HostingServiceException`, which
  meant that the second one was dead code.

Testing Done:
Ran unit tests.

    

   
  		
  f0e538776dd41aebd9e50bab6a99ab458787c279
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/admin/siteconfig.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/attachments/mimetypes.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/cmdline/rbsite.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/cmdline/rbssh.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/hostingsvcs/beanstalk.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/hostingsvcs/bitbucket.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/hostingsvcs/github.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/hostingsvcs/kiln.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/integrations/models.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/ui/base.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/core.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/cvs.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/testing/__init__.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/diff.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/draft_diffcommit.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/repository_info.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/review_request.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...