Summary

Do some cleanup on exception handling.

Review Request #12083 — Created Feb. 24, 2022 and submitted March 4, 2022, 3:23 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-5.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change fixes some mechanical issues with exception handling:

We had a few places that had bare except syntax. These have been
updated to explicitly list exception types.
A number of places were assigning the exception to e but not using
it.
In one place, we had two handlers for HostingServiceException, which
meant that the second one was dead code.

Testing Done

Ran unit tests.

Commits

Summary	ID
Do some cleanup on exception handling. This change fixes some mechanical issues with exception handling: - We had a few places that had bare `except` syntax. These have been updated to explicitly list exception types. - A number of places were assigning the exception to `e` but not using it. - In one place, we had two handlers for `HostingServiceException`, which meant that the second one was dead code. Testing Done: Ran unit tests.	f0e538776dd41aebd9e50bab6a99ab458787c279

Summary

Do some cleanup on exception handling.

This change fixes some mechanical issues with exception handling: - We had a few places that had bare `except` syntax. These have been updated to explicitly list exception types. - A number of places were assigning the exception to `e` but not using it. - In one place, we had two handlers for `HostingServiceException`, which meant that the second one was dead code. Testing Done: Ran unit tests.

f0e538776dd41aebd9e50bab6a99ab458787c279

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to django-3.2 (56d2085)