Add storage of UNIX file mode metadata from diffs.

 






 

 


  Review Request #12067
  —
  Created Feb. 20, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-4.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
ParsedDiffFile and FileDiff now contain storage of old and new UNIX

file modes, which may be provided by the diff parser. These are

ultimately stored in FileDiff.extra_data as old_unix_mode and

new_unix_mode.


Right now, nothing consumes these within Review Board, but clients will

be able to make use of these to reflect file modes. In time, the plan is

to show these in the diff viewer.

 








  


 
 

  
All unit tests pass.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Add storage of UNIX file mode metadata from diffs.
     
`ParsedDiffFile` and `FileDiff` now contain storage of old and new UNIX
file modes, which may be provided by the diff parser. These are
ultimately stored in `FileDiff.extra_data` as `old_unix_mode` and
`new_unix_mode`.

Right now, nothing consumes these within Review Board, but clients will
be able to make use of these to reflect file modes. In time, the plan is
to show these in the diff viewer.

    

   
  		
  1db800a3284cc178539b14bfd9ea2e930bd7a241
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/diffviewer/filediff_creator.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/parser.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/models/filediff.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/testing/mixins.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_diffx_parser.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_filediff.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_filediff_creator.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...