Add formal storage of symlink targets when parsing diffs.

 






 

 


  Review Request #12066
  —
  Created Feb. 20, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-4.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
ParsedDiffFile and FileDiff both contained information on whether a

file was a symlink, but nothing more than that. There was no information

on targets, meaning that it was up to the diff implementation and

patch to generate a suitable symlink for display or when applying a

patch. This wasn't ideal.


ParsedDiffFile now contains typed attributes for old and new symlink

targets. These are optional, but can be set by the diff parser. The

DiffX parser is currently the only one that sets these.


FileDiff provides attributes for getting or setting all symlink state.

These are is_symlink, old_symlink_target, and new_symlink_target.

These all wrap extra_data, giving us a formal way of working with

these attributes.


An upcoming SCM will need thess. A separate upcoming change will enable

this support for Git (and Mercurial by extension). Eventually, we'll be

able to use these to avoid some hacks we're currently using to render

symlink changes in diffs.


This will also be useful for Review Bot and RBTools, which will benefit

from being able to know how to correctly manage symlinks.

 








  


 
 

  
Unit tests pass.

 







 









 





  








 




 







   

    
    
Diff Revision 2


This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Add formal storage of symlink targets when parsing diffs.
     
`ParsedFileDiff` and `FileDiff` both contained information on whether a
file was a symlink, but nothing more than that. There was no information
on targets, meaning that it was up to the diff implementation and
`patch` to generate a suitable symlink for display or when applying a
patch. This wasn't ideal.

`ParsedFileDiff` now contains typed attributes for old and new symlink
targets. These are optional, but can be set by the diff parser. The
DiffX parser is currently the only one that sets these.

`FileDiff` provides attributes for getting or setting all symlink state.
These are `is_symlink`, `old_symlink_target`, and `new_symlink_target`.
These all wrap `extra_data`, giving us a formal way of working with
these attributes.

An upcoming SCM will need thess. A separate upcoming change will enable
this support for Git (and Mercurial by extension). Eventually, we'll be
able to use these to avoid some hacks we're currently using to render
symlink changes in diffs.

This will also be useful for Review Bot and RBTools, which will benefit
from being able to know how to correctly manage symlinks.

    

   
  		
  e07f58b77bcea51808d0941ccc92af108797d694
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/diffviewer/filediff_creator.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/parser.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/models/filediff.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/testing/mixins.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_diffx_parser.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_filediff.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_filediff_creator.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...