• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    

  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Fix refreshing the list of tools.
    
 
    

    



 
    
 
    

  Review Request #12062
  —
  Created Feb. 17, 2022 and submitted 

 
    


    




    




    






 
    
  
    
   Information

  
    



    
 
 
    
  chipx86
 
    

    





    
 
 
    
  ReviewBot
 
    

    





    
 
 
    
  release-2.0.x
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  reviewbot
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    When refreshing the list of tools, we attempted to render a template to
    
send back to the API call. This was passing a legacy parameter to
    
RequestContext, which no longer works, causing the refresh spinner to
    
spin forever and for a traceback to appear in reviewboard.log.
    

    This fortunately did not impede the refresh operation, but it did give
    
the appearance that refresh had failed.
    

    This change fixes that up, removing the template and just returning a
    
hard-coded result.
    
 
    

    





  

    
 
 
    
  
    Tested refreshing tools. It successfully refreshed and reloaded the page.
    
 
    

    




 
    

    





    
 
    




  
    
 
 
    
  


    
 
    
  
   
    

    Summary
    ID

   
    
      
  

   
    

    

     
    
      Fix refreshing the list of tools.
      
    When refreshing the list of tools, we attempted to render a template to
send back to the API call. This was passing a legacy parameter to
`RequestContext`, which no longer works, causing the refresh spinner to
spin forever and for a traceback to appear in reviewboard.log.

This fortunately did not impede the refresh operation, but it did give
the appearance that refresh had failed.

This change fixes that up, removing the template and just returning a
hard-coded result.
    
     
    

        		
    6e926a017d1a45c107907a0263d6f02e795899ce

   
    


      
 
    

    
    
 
    

    






 









 
    

    



  
    
 
    

    


    












    
 




 

    


 













    
 





 
    
  
    
   
    



david




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
david


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      Ship It!
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



chipx86




   
    
   
    
  
    
 
    


 
    
  
    

   
    
   
    
    
     Review request changed
    
    
   
    

  
    
  
    
  
    




    

  
    
   
    
    Status:
   
    
   
    

    Completed

   
    
  
    



  
    
   
    
    Change Summary:
   
    
   
    
    
    Pushed to release-2.0.x (e64d7dd)