This change has been discarded.

Describe the reason it's discarded (optional):

This work has moved to /r/12296

Summary

Add root comments APIs

Review Request #12037 — Created Feb. 4, 2022 and discarded 2 years, 11 months ago — Latest diff uploaded 3 years, 1 month ago

Information

Owner

Chaoyu*

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description*


Registered root diff comments, root file attachment comments and root general comments API
Support GET method for list resources with query parameter:
Shared query parameters : review-request-id=<review-request-id> , review-id=<review-id>, user=<user-username>, is-reply
file-diff-id, line and interdiff-revision  for diff comments, and file-attachment-id file-name for file attachment comments
Unit tests suites for comments API
Added added webapi_request_fields decorator to get_list for request parameters documentation
Updated the WebAPI documentations

Testing Done


Added unit tests for diff-comment, general-comment and file-attachment-comment with list resource and GET method

Changes between revision 8 and 9

orig

Commits

Summary	ID	Author
register comments root APIs	6ead118a5c814c3e85d03f98aa1349bb195c0ee7	charlie-xiang
fix a bug in base file attachment comment from last commit	319cd6df612ef18096dc563ebfb8ec26ae48e340	charlie-xiang
add user name filter and add diff comment test suites	be7279791b2dd90f0c9dbd6fe5675589a30944e3	charlie-xiang
add user tests to diff comment	4ad0f51bbad5d023a3e14929e493b409aafa9e2b	charlie-xiang
add filediff id query parameter for diff comment, file attachment parameters ...	85dac98dfa7185f4d2d8846de1e1415627c21908	charlie-xiang
add last-updated-from, to and is_reply filters	3b28c1cc1faf70a2790152a385c54cf8219a0683	charlie-xiang
address reviews feedback	1ca9fbaccae7ca5cabecb4083f604b0cee834683	charlie-xiang
added tests for last-updated and is-reply	b075e5d5dbc4104ea376b3a8e521aabfb2109fb9	charlie-xiang
add webapi_request_fields documentations and resource class docstring	b84f8c26fa21f60439c6fa54cc4f0d1a7c3289bf	charlie-xiang
register comments root APIs	44288f2e38715f36d3fe785d1a37cf431c58dd9e	charlie-xiang
fix a bug in base file attachment comment from last commit	e95ff3fa71a355454f66cd5ab76b4f600a2bd479	charlie-xiang
add user name filter and add diff comment test suites	f99ddf9ce372cf9d8152cf0be0eb536f9c4d5375	charlie-xiang
add user tests to diff comment	6384876fee680c473c4174cfce2e74417e5876f1	charlie-xiang
add filediff id query parameter for diff comment, file attachment parameters ...	03f77eb15a8086d59b88a1d68e1f337a6188172f	charlie-xiang
add last-updated-from, to and is_reply filters	b9c04bb7e6e2f9849c9918c50d8c3b2023e28909	charlie-xiang
address reviews feedback	4c07e01cd4943277a946e130a414b888c02d74a9	charlie-xiang
added tests for last-updated and is-reply	f886553f0031fce678d428573cde46d82165e975	charlie-xiang
add webapi_request_fields documentations and resource class docstring	a09404b357879088b64add7b870a4c37b56c34b7	charlie-xiang
update to use parsed parameters and added doc tree	c11bf2d737548101f44ea7a92e9469b20cde8a3d	charlie-xiang

Files

	docs/manual/webapi/2.0/resources/index.rst
	docs/manual/webapi/2.0/resources/root-diff-comment-list.rst
	docs/manual/webapi/2.0/resources/root-file-attachment-comment-list.rst
	docs/manual/webapi/2.0/resources/root-general-comment-list.rst
	reviewboard/webapi/resources/base_diff_comment.py
	reviewboard/webapi/resources/base_file_attachment_comment.py
	reviewboard/webapi/resources/base_review_general_comment.py
	reviewboard/webapi/resources/root.py
	reviewboard/webapi/resources/root_diff_comment.py
	reviewboard/webapi/resources/root_file_attachment_comment.py
	reviewboard/webapi/resources/root_general_comment.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/urls.py

docs/manual/webapi/2.0/resources/index.rst

docs/manual/webapi/2.0/resources/root-diff-comment-list.rst

docs/manual/webapi/2.0/resources/root-file-attachment-comment-list.rst

docs/manual/webapi/2.0/resources/root-general-comment-list.rst

reviewboard/webapi/resources/base_diff_comment.py

reviewboard/webapi/resources/base_file_attachment_comment.py

reviewboard/webapi/resources/base_review_general_comment.py

reviewboard/webapi/resources/root.py

reviewboard/webapi/resources/root_diff_comment.py

reviewboard/webapi/resources/root_file_attachment_comment.py

reviewboard/webapi/resources/root_general_comment.py

reviewboard/webapi/tests/mimetypes.py

reviewboard/webapi/tests/urls.py