Add root comments APIs

 






 

 


  Review Request #12037
  —
  Created Feb. 4, 2022 and discarded  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  Chaoyu
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
    

  • Registered root diff comments, root file attachment comments and root general comments API
    • 

  • Support GET method for list resources with query parameter:
    • 

  • Shared query parameters : review-request-id=<review-request-id> , review-id=<review-id>, user=<user-username>, is-reply
    • 

  • file-diff-id, line and interdiff-revision  for diff comments, and file-attachment-id file-name for file attachment comments
    • 

  • Unit tests suites for comments API
    • 

  • Added added webapi_request_fields decorator to get_list for request parameters documentation
    • 

  • Updated the WebAPI documentations
    • 


 








  


 
 

  
    

  • Added unit tests for diff-comment, general-comment and file-attachment-comment with list resource and GET method
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 10 (Latest)



    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9
10

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    
register comments root APIs

   
  		
  7697a1e0439c7a09f66f69018512b1d9d62e586d
  charlie-xiang
 


 
  
   
  
  
   
  
 
 
  
   
    
fix a bug in base file attachment comment from last commit

   
  		
  b2be67042a927571a7bb4d876632c28c576a5a41
  charlie-xiang
 


 
  
   
  
  
   
  
 
 
  
   
    
add user name filter and add diff comment test suites

   
  		
  c3357d44d9b108848863dcc1f3e25fab012453e9
  charlie-xiang
 


 
  
   
  
  
   
  
 
 
  
   
    
add user tests to diff comment

   
  		
  26b7346d85eeb5e28094a56d7313e8d3ce575996
  charlie-xiang
 


 
  
   
  
  
   
  
 
 
  
   
    
add filediff id query parameter for diff comment, file attachment parameters ...

   
  		
  31fbbc2ad10218658aab0518b2525c5ee27bf609
  charlie-xiang
 


 
  
   
  
  
   
  
 
 
  
   
    
add last-updated-from, to and is_reply filters

   
  		
  c062506ea81a860c09d0b08baafcd5d88909e0fb
  charlie-xiang
 


 
  
   
  
  
   
  
 
 
  
   
    
address reviews feedback

   
  		
  7ab70cc20ad219423ec49ade08b55e33c0e49853
  charlie-xiang
 


 
  
   
  
  
   
  
 
 
  
   
    
added tests for last-updated and is-reply

   
  		
  a35f5434b4190a51f9cae711695945d161113543
  charlie-xiang
 


 
  
   
  
  
   
  
 
 
  
   
    
add webapi_request_fields documentations and resource class docstring

   
  		
  5033f62280090aff629e91710f280cd346d36f58
  charlie-xiang
 


 
  
   
  
  
   
  
 
 
  
   
    
update to use parsed parameters and added doc tree

   
  		
  4870f7693329b6237d888408b38754a7b3077a52
  charlie-xiang
 


 
  
   
  
  
   
  
 
 
  
   
    
fix review comments

   
  		
  bf58ea40bd2d105d87bca9bdab64d58759037b61
  charlie-xiang
 




    


    
    

   

  

 









 

  

   
    

     
      
      docs/manual/webapi/2.0/resources/index.rst
     
    

   
  

 



 

  

   
    

     
      
      docs/manual/webapi/2.0/resources/root-diff-comment-list.rst
     
    

   
  

 



 

  

   
    

     
      
      docs/manual/webapi/2.0/resources/root-file-attachment-comment-list.rst
     
    

   
  

 



 

  

   
    

     
      
      docs/manual/webapi/2.0/resources/root-general-comment-list.rst
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/base_diff_comment.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/base_file_attachment_comment.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/base_review_general_comment.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/root.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/root_diff_comment.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/root_file_attachment_comment.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/root_general_comment.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/tests/mimetypes.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/tests/test_root_diff_comment.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/tests/test_root_file_attachment_comment.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/tests/test_root_general_comment.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/tests/urls.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...