Update URL patterns to use new path() and re_path().

 






 

 


  Review Request #12022
  —
  Created Jan. 29, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Django 2+ provides a new method for definings URLs, path(). This is

much simpler for basic cases, and makes URL patterns more readable. In

addition, the old url() method has been renamed to re_path(), and a

warning is raised when using the old name, so switch to that too.


As part of this, I changed the file attachment URLs to actually parse

UUIDs using Django's new converter for that. This required making a

change in the test create_file_attachment_base method to use real

UUIDs instead of the string "test-uuid".

 








  


 
 

  
Ran unit tests.

 







 









 





  








 




 







   

    
    
Changes between revision 3 and 4



    

 

 

 

 
orig
1
2
3
4

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Update URL patterns to use new path() and re_path().
     
Django 2+ provides a new method for definings URLs, `path()`. This is
much simpler for basic cases, and makes URL patterns more readable. In
addition, the old `url()` method has been renamed to `re_path()`, and a
warning is raised when using the old name, so switch to that too.

Testing Done:
Ran unit tests.

    

   
  		
  1b5ce6ea5a19776a61d70cef708b2dd708b685ec
  David Trowbridge
 


 
  
 
 
  
   
    

     Update URL patterns to use new path() and re_path().
     
Django 2+ provides a new method for definings URLs, `path()`. This is
much simpler for basic cases, and makes URL patterns more readable. In
addition, the old `url()` method has been renamed to `re_path()`, and a
warning is raised when using the old name, so switch to that too.

As part of this, I changed the file attachment URLs to actually parse
UUIDs using Django's new converter for that. This required making a
change in the test `create_file_attachment_base` method to use real
UUIDs instead of the string "test-uuid".

Testing Done:
Ran unit tests.

    

   
  		
  986690fae4a4de27c24130076e64cf251fe64447
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/admin/urls.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/cmdline/rbext.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...