Summary

Update URL patterns to use new path() and re_path().

Review Request #12022 — Created Jan. 29, 2022 and submitted Feb. 7, 2022, 11:07 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Django 2+ provides a new method for definings URLs, path(). This is
much simpler for basic cases, and makes URL patterns more readable. In
addition, the old url() method has been renamed to re_path(), and a
warning is raised when using the old name, so switch to that too.

As part of this, I changed the file attachment URLs to actually parse
UUIDs using Django's new converter for that. This required making a
change in the test create_file_attachment_base method to use real
UUIDs instead of the string "test-uuid".

Testing Done

Ran unit tests.

Commits

Summary	ID
Update URL patterns to use new path() and re_path(). Django 2+ provides a new method for definings URLs, `path()`. This is much simpler for basic cases, and makes URL patterns more readable. In addition, the old `url()` method has been renamed to `re_path()`, and a warning is raised when using the old name, so switch to that too. As part of this, I changed the file attachment URLs to actually parse UUIDs using Django's new converter for that. This required making a change in the test `create_file_attachment_base` method to use real UUIDs instead of the string "test-uuid". Testing Done: Ran unit tests.	986690fae4a4de27c24130076e64cf251fe64447

Summary

Update URL patterns to use new path() and re_path().

Django 2+ provides a new method for definings URLs, `path()`. This is much simpler for basic cases, and makes URL patterns more readable. In addition, the old `url()` method has been renamed to `re_path()`, and a warning is raised when using the old name, so switch to that too. As part of this, I changed the file attachment URLs to actually parse UUIDs using Django's new converter for that. This required making a change in the test `create_file_attachment_base` method to use real UUIDs instead of the string "test-uuid". Testing Done: Ran unit tests.

986690fae4a4de27c24130076e64cf251fe64447

Issues

Description	From	Last Updated
E231 missing whitespace after ','	reviewbot	Jan. 29, 2022, 10:15 a.m.
Second line isn't aligned right.	chipx86	Feb. 2, 2022, 10:54 a.m.
Alignment isn't correct.	chipx86	Feb. 2, 2022, 10:54 a.m.
This file's change seems unrelated.	chipx86	Jan. 31, 2022, 2:46 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/custom_evolutions/oauth2_provider/move_to_migrations.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```

Commits:

	Summary	ID
	Update URL patterns to use new path() and re_path(). Django 2+ provides a new method for definings URLs, `path()`. This is much simpler for basic cases, and makes URL patterns more readable. In addition, the old `url()` method has been renamed to `re_path()`, and a warning is raised when using the old name, so switch to that too. Testing Done: Ran unit tests.	55648844e02dd49a8cd706501070af855b674c36
	Update URL patterns to use new path() and re_path(). Django 2+ provides a new method for definings URLs, `path()`. This is much simpler for basic cases, and makes URL patterns more readable. In addition, the old `url()` method has been renamed to `re_path()`, and a warning is raised when using the old name, so switch to that too. Testing Done: Ran unit tests.	987a2e1be61ef4ebbd46265129ccdd625e113665

Diff:

Revision 2 (+688 -690)

Show changes

	docs/manual/extending/extensions/configuration.rst
	docs/manual/extending/extensions/hooks/url-hook.rst
	reviewboard/urls.py
	reviewboard/accounts/urls.py
	reviewboard/admin/urls.py
	reviewboard/cmdline/rbext.py
	reviewboard/datagrids/urls.py
	reviewboard/hostingsvcs/beanstalk.py
	13 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Indentation in docs.

Commits:

	Summary	ID
	Update URL patterns to use new path() and re_path(). Django 2+ provides a new method for definings URLs, `path()`. This is much simpler for basic cases, and makes URL patterns more readable. In addition, the old `url()` method has been renamed to `re_path()`, and a warning is raised when using the old name, so switch to that too. Testing Done: Ran unit tests.	987a2e1be61ef4ebbd46265129ccdd625e113665
	Update URL patterns to use new path() and re_path(). Django 2+ provides a new method for definings URLs, `path()`. This is much simpler for basic cases, and makes URL patterns more readable. In addition, the old `url()` method has been renamed to `re_path()`, and a warning is raised when using the old name, so switch to that too. Testing Done: Ran unit tests.	1b5ce6ea5a19776a61d70cef708b2dd708b685ec

Diff:

Revision 3 (+698 -700)

Show changes

	docs/manual/extending/extensions/configuration.rst
	docs/manual/extending/extensions/hooks/url-hook.rst
	reviewboard/urls.py
	reviewboard/accounts/urls.py
	reviewboard/admin/urls.py
	reviewboard/cmdline/rbext.py
	reviewboard/datagrids/urls.py
	reviewboard/hostingsvcs/beanstalk.py
	13 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/admin/urls.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Second line isn't aligned right.
```
reviewboard/cmdline/rbext.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Alignment isn't correct.
```

reviewboard/testing/testcase.py (Diff revision 3)

The issue has been dropped. Show all issues

This file's change seems unrelated.

david Jan. 31, 2022, 2:46 p.m.

Actually it is part of the change. I changed the file attachment URL to use the uuid converter, which actually parses UUID format. The old "test-uuid" string didn't parse anymore.

Description:

		Django 2+ provides a new method for definings URLs, `path()`. This is
		much simpler for basic cases, and makes URL patterns more readable. In
		addition, the old `url()` method has been renamed to `re_path()`, and a
		warning is raised when using the old name, so switch to that too.
	+
	+	As part of this, I changed the file attachment URLs to actually parse
	+	UUIDs using Django's new converter for that. This required making a
	+	change in the test `create_file_attachment_base` method to use real
	+	UUIDs instead of the string "test-uuid".

Commits:

	Summary	ID
	Update URL patterns to use new path() and re_path(). Django 2+ provides a new method for definings URLs, `path()`. This is much simpler for basic cases, and makes URL patterns more readable. In addition, the old `url()` method has been renamed to `re_path()`, and a warning is raised when using the old name, so switch to that too. Testing Done: Ran unit tests.	1b5ce6ea5a19776a61d70cef708b2dd708b685ec
	Update URL patterns to use new path() and re_path(). Django 2+ provides a new method for definings URLs, `path()`. This is much simpler for basic cases, and makes URL patterns more readable. In addition, the old `url()` method has been renamed to `re_path()`, and a warning is raised when using the old name, so switch to that too. As part of this, I changed the file attachment URLs to actually parse UUIDs using Django's new converter for that. This required making a change in the test `create_file_attachment_base` method to use real UUIDs instead of the string "test-uuid". Testing Done: Ran unit tests.	986690fae4a4de27c24130076e64cf251fe64447

Diff:

Revision 4 (+716 -716)

Show changes

	docs/manual/extending/extensions/configuration.rst
	docs/manual/extending/extensions/hooks/url-hook.rst
	reviewboard/urls.py
	reviewboard/accounts/urls.py
	reviewboard/admin/urls.py
	reviewboard/cmdline/rbext.py
	reviewboard/datagrids/urls.py
	reviewboard/hostingsvcs/beanstalk.py
	13 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to django-3.2 (a3249c8)