Fix a broken try/except/else clause.

 






 

 


  Review Request #12010
  —
  Created Jan. 26, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
We had a place where we were calling raise from within a try

statement's else clause. This doesn't make sense because else is

called when the body of the try completed successfully, so there's

nothing to re-raise.

 








  


 
 

  
Ran unit tests.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Fix a broken try/except/else clause.
     
We had a place where we were calling `raise` from within a `try`
statement's `else` clause. This doesn't make sense because `else` is
called when the body of the try completed successfully, so there's
nothing to re-raise.

Testing Done:
Ran unit tests.

    

   
  		
  9b608b99416a6d596aeb6c53d00fb251957de011
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/scmtools/tests/testcases.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...