Summary

Make @superuser_required delegate to @login_required.

Review Request #12005 — Created Jan. 26, 2022 and submitted Feb. 7, 2022, 11:07 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

We had implemented our own login-required functionality inside the
@superuser_required decorator, but this didn't handle some of the API
changes that have happened upstream in Django. This change updates it so
that we just delegate to the built-in @login_required first.

Testing Done


Ran unit tests.
Tested that accessing various admin pages (DB, siteconfig forms) when

  logged out correctly redirected to the login form, and then back to

  the expected page.

Commits

Summary	ID
Make @superuser_required delegate to @login_required. We had implemented our own login-required functionality inside the @superuser_required decorator, but this didn't handle some of the API changes that have happened upstream in Django. This change updates it so that we just delegate to the built-in @login_required first. Testing Done: Ran unit tests.	4ceb9071e7ee53abeb3f3a93b2646b905afcad4a

Issues

Description	From	Last Updated
Can you check on the login experience now with the admin UI, by going to both a database page and …	chipx86	Feb. 2, 2022, 11:41 a.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Can you check on the login experience now with the admin UI, by going to both a database page and something more under our control (say, extensions list) as an anonymous user? I want to make sure everything is identical and points to our login page.

Can you also turn on an auth backend that customizes the login form in some way and verify that those customizations are reflected?

david Feb. 2, 2022, 11:37 a.m.

I'm not sure how customized login forms would matter. @login_required just redirects to the login URL.

Testing Done:: ~
Ran unit tests.
~
Ran unit tests.
+
Tested that accessing various admin pages (DB, siteconfig forms) when
logged out correctly redirected to the login form, and then back to
the expected page.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to django-3.2 (c009ead)

~		Ran unit tests.
	~	Ran unit tests.
	+	Tested that accessing various admin pages (DB, siteconfig forms) when logged out correctly redirected to the login form, and then back to the expected page.