• 
  
    
 
    
 
    

    



    
    
    
    
     
    




    
 
    

  
    



    
 

 

  

  

 

    


  
    





    
 
    



  

    
 
 
    
  
    Tweak check for request.resolver_match in extension templatetags.
    
 
    

    



 
    
 
    

  Review Request #12000
  —
  Created Jan. 26, 2022 and submitted 

 
    


    




    




    






 
    
  
    
   Information

  
    



    
 
 
    
  david
 
    

    





    
 
 
    
  Djblets
 
    

    





    
 
 
    
  release-3.x
 
    

    





    
 
 
    
  
 
    

    





    
 
 
    
  
 
    

    



 
    



 
    
  
    
   Reviewers

  
    



    
 
 
    
  djblets
 
    

    





    
 
 
    
  
 
    

    



 
    



    


    
 
    




  

    
 
 
    
  
    I recently added a check inside the init_js_extensions method to check
    
whether resolver_match was present on the request. This can be missing
    
in the case where middleware decides to render a page instead of
    
delegating to the regular view (typically something like a 403). The
    
check I added wasn't quite correct, and could still fail in some cases.
    
This change updates it to address those cases.
    
 
    

    





  

    
 
 
    
  
    Ran Review Board test suite where this was being hit.
    
 
    

    




 
    

    





    
 
    




  
    
 
 
    
  


    
 
    
  
   
    

    Summary
    ID

   
    
      
  

   
    

    

     
    
      Tweak check for request.resolver_match in extension templatetags.
      
    I recently added a check inside the `init_js_extensions` method to check
whether `resolver_match` was present on the request. This can be missing
in the case where middleware decides to render a page instead of
delegating to the regular view (typically something like a 403). The
check I added wasn't quite correct, and could still fail in some cases.
This change updates it to address those cases.

Testing Done:
Ran Review Board test suite where this was being hit.
    
     
    

        		
    ca9c3887e038fd6b18ff7951bdfab4d1ea6a687f

   
    


      
 
    

    
    
 
    

    






 









 
    

    



  
    
 
    

    


    












    
 




 

    


 













    
 





 
    
  
    
   
    



chipx86




   
    
   
    





    
  
    
 
    


 
    
  
    

   
    
   
    
    
     
chipx86


    
    
   
    

  
    
  
    
  
    


      




    1. 
 
      
  
      
   
      Ship It!
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      2. 















    2. 
 
      
  
      
   
      
  
      
 
      

 
      
  


      
 
      
 
        

  

 
      


      

 
      

      3. 


    

  
    
 
    

    












    
 



 
    
  
    
   
    



david




   
    
   
    
  
    
 
    


 
    
  
    

   
    
   
    
    
     Review request changed
    
    
   
    

  
    
  
    
  
    




    

  
    
   
    
    Status:
   
    
   
    

    Completed

   
    
  
    



  
    
   
    
    Change Summary:
   
    
   
    
    
    Pushed to release-3.x (644c2a2)