Summary

Always use test_users fixture when we use test_site.

Review Request #11990 — Created Jan. 24, 2022 and submitted Feb. 7, 2022, 11:07 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

The test_site fixture references an ID from the test_users fixture.
Django 1.x didn't seem to care, but newer versions will error out with
an IntegrityError.

Testing Done

Ran unit tests.

Commits

Summary	ID
Always use test_users fixture when we use test_site. The test_site fixture references an ID from the test_users fixture. Django 1.x didn't seem to care, but newer versions will error out with an IntegrityError. Testing Done: Ran unit tests.	348df55e867a25d64fe17c003fb72179b739f9e4

Issues

Description	From	Last Updated
E303 too many blank lines (2)	reviewbot	Jan. 24, 2022, 6:48 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/tests/test_base.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E303 too many blank lines (2)
```

Commits:

	Summary	ID
	Always use test_users fixture when we use test_site. The test_site fixture references an ID from the test_users fixture. Django 1.x didn't seem to care, but newer versions will error out with an IntegrityError. Testing Done: Ran unit tests.	e01a4bbd521373dadbe4e3b5aca8928e4249a6ab
	Always use test_users fixture when we use test_site. The test_site fixture references an ID from the test_users fixture. Django 1.x didn't seem to care, but newer versions will error out with an IntegrityError. Testing Done: Ran unit tests.	348df55e867a25d64fe17c003fb72179b739f9e4

Diff:

Revision 2 (+56 -68)

Show changes

	reviewboard/accounts/tests/test_template_tags.py
	reviewboard/features/tests.py
	reviewboard/notifications/tests/test_email_sending.py
	reviewboard/scmtools/tests/test_perforce.py
	reviewboard/scmtools/tests/test_repository_manager.py
	reviewboard/site/tests.py
	reviewboard/webapi/tests/test_base.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to django-3.2 (b52bbfb)