Use .set() when assigning multiple relations.
Review Request #11989 — Created Jan. 24, 2022 and submitted — Latest diff uploaded
Using the assignment operator for setting the far side of a relation
such asManyToManyFieldorForeignKeynow generates an error
instructing us to use.set()instead.In many cases, we were using
.set()to set a list of relations on
newly-created objects within tests. In these cases, we can save one
query per use by using.add()instead.
Ran unit tests.
Diff Revision 2
This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.
orig
1
2
3
Commits
Files
| reviewboard/accounts/tests/test_user.py |
|---|
| reviewboard/diffviewer/tests/test_diffutils.py |
|---|
| reviewboard/notifications/tests/test_email_sending.py |
|---|
| reviewboard/notifications/tests/test_email_utils.py |
|---|
| reviewboard/reviews/builtin_fields.py |
|---|
| reviewboard/reviews/models/review_request_draft.py |
|---|
| reviewboard/reviews/tests/test_conditions.py |
|---|
| reviewboard/reviews/tests/test_counters.py |
|---|
| reviewboard/reviews/tests/test_review_request_draft.py |
|---|
| reviewboard/reviews/tests/test_reviews_diff_fragment_view.py |
|---|
| reviewboard/search/tests/test_search.py |
|---|
| reviewboard/testing/testcase.py |
|---|
| reviewboard/webapi/resources/review_request_draft.py |
|---|
| reviewboard/webapi/tests/test_change.py |
|---|
| reviewboard/webapi/tests/test_diffcommit.py |
|---|
| reviewboard/webapi/tests/test_review_group_user.py |
|---|
| reviewboard/webapi/tests/test_review_request_draft.py |
|---|
| reviewboard/webapi/tests/test_search.py |
|---|
| reviewboard/webapi/tests/test_user.py |
|---|
| reviewboard/webapi/tests/test_webhook.py |
|---|