Add on_delete to ForeignKey definitions.

 






 

 


  Review Request #11988
  —
  Created Jan. 24, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Django has made the on_delete argument to ForeignKey mandatory.

Until now, this has defaulted to CASCADE, which makes it easy to

unintentionally delete things that shouldn't be deleted. Making it a

required argument forces developers to think about each model and how it

should behave.


This change explicitly sets on_delete for every relation we have. Most

of these are CASCADE, but the diff data ones are SET_NULL because

those are effectively a one-to-many relation, and we don't want to

delete diff data that may be shared by other diffs.

 








  


 
 

  
Ran unit tests.

 







 









 





  








 




 







   

    
    
Changes between revision 2 and 3



    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Add on_delete to ForeignKey definitions.
     
Django has made the `on_delete` argument to `ForeignKey` mandatory.
Until now, this has defaulted to `CASCADE`, which makes it easy to
unintentionally delete things that shouldn't be deleted. Making it a
required argument forces developers to think about each model and how it
should behave.

Testing Done:
Ran unit tests.

    

   
  		
  1997c4e771a9be4ff6624852af91dc5b06731d33
  David Trowbridge
 


 
  
 
 
  
   
    

     Add on_delete to ForeignKey definitions.
     
Django has made the `on_delete` argument to `ForeignKey` mandatory.
Until now, this has defaulted to `CASCADE`, which makes it easy to
unintentionally delete things that shouldn't be deleted. Making it a
required argument forces developers to think about each model and how it
should behave.

This change explicitly sets `on_delete` for every relation we have. Most
of these are `CASCADE`, but the diff data ones are `SET_NULL` because
those are effectively a one-to-many relation, and we don't want to
delete diff data that may be shared by other diffs.

Testing Done:
Ran unit tests.

    

   
  		
  a6eb4c8323c57a65ff0f425ab8ac8ec907436ea4
  David Trowbridge
 




    


    


      
Files


      

    

    

   

  

 
















     

    

   

  

  

   
   Loading...