Add on_delete to ForeignKey definitions.
Review Request #11988 — Created Jan. 24, 2022 and submitted — Latest diff uploaded
Django has made the
on_delete
argument toForeignKey
mandatory.
Until now, this has defaulted toCASCADE
, which makes it easy to
unintentionally delete things that shouldn't be deleted. Making it a
required argument forces developers to think about each model and how it
should behave.This change explicitly sets
on_delete
for every relation we have. Most
of these areCASCADE
, but the diff data ones areSET_NULL
because
those are effectively a one-to-many relation, and we don't want to
delete diff data that may be shared by other diffs.
Ran unit tests.
Diff Revision 3 (Latest)
orig
1
2
3
Commits
Files
reviewboard/accounts/models.py |
---|
reviewboard/attachments/models.py |
---|
reviewboard/changedescs/models.py |
---|
reviewboard/diffviewer/models/diffcommit.py |
---|
reviewboard/diffviewer/models/diffset.py |
---|
reviewboard/diffviewer/models/filediff.py |
---|
reviewboard/hostingsvcs/models.py |
---|
reviewboard/integrations/models.py |
---|
reviewboard/notifications/models.py |
---|
reviewboard/oauth/models.py |
---|
reviewboard/reviews/models/base_comment.py |
---|
reviewboard/reviews/models/default_reviewer.py |
---|
reviewboard/reviews/models/diff_comment.py |
---|
reviewboard/reviews/models/file_attachment_comment.py |
---|
reviewboard/reviews/models/group.py |
---|
reviewboard/reviews/models/review.py |
---|
reviewboard/reviews/models/review_request.py |
---|
reviewboard/reviews/models/review_request_draft.py |
---|
reviewboard/reviews/models/screenshot_comment.py |
---|
reviewboard/reviews/models/status_update.py |
---|
reviewboard/scmtools/models.py |
---|
reviewboard/webapi/models.py |
---|