• 
      

    Update pipeline storage class.

    Review Request #11979 — Created Jan. 22, 2022 and submitted

    Information

    Djblets
    release-3.x

    Reviewers

    The old PipelineCachedStorage class has been removed, because Django
    removed the CachedStaticFilesStorage class. The reasoning here is that
    this storage backend had non-specified "intractable problems". Django
    advises to switch to ManifestStaticFilesStorage, and Pipeline does
    have a storage class that inherits from this. This class does the same
    hashing for filenames that the old cached storage does. The major
    difference is that it also looks for those files in the manifest file.
    This can be disabled via a class attribute, so I've added a subclass of
    it that uses the backend for its hashing but turns off manifest
    checking.

    Ran unit tests.

    Summary ID
    Update pipeline storage class.
    The old `PipelineCachedStorage` class has been removed, because Django removed the `CachedStaticFilesStorage` class. The reasoning here is that this storage backend had non-specified "intractable problems". Django advises to switch to `ManifestStaticFilesStorage`, and Pipeline does have a storage class that inherits from this. This class does the same hashing for filenames that the old cached storage does. The major difference is that it also looks for those files in the manifest file. This can be disabled via a class attribute, so I've added a subclass of it that uses the backend for its hashing but turns off manifest checking. Testing Done: Ran unit tests.
    ada660f8082d7692a28614c44556981226e76744
    Description From Last Updated

    Missing a blank line.

    chipx86chipx86
    chipx86
    1. 
        
    2. djblets/pipeline/storage.py (Diff revision 1)
       
       
       
      Show all issues

      Missing a blank line.

    3. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-3.x (79162e8)