rbtools support diff filename instead of calling scm to generate diff

 






 

 


  Review Request #1197
  —
  Created Nov. 5, 2009 and submitted — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  clach04
 









 
 

  RBTools
 









 
 

  
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  chipx86
 






 








 





  


 
 

  
Added new flag "--diff-filename" that specifies the name of the file where diffs should be read from instead of using SCM client to generate diff.

Due to the way some (git) SCMClient subclasses change the current directory the new code has to take a backup of the starting directory if diff filename is not fully specified/qualified.

NOTE at this time only reading from a file is supported.

 








  


 
 

  
git diff --full-index HEAD >mydiff
./postreview.py --server=http://reviews.reviewboard.org/ --diff-filename mydiff -r 1197

I.e. this review was posted with the new code