This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-3.x (eed78df)

Summary

Change middleware to always be new-style.

Review Request #11961 — Created Jan. 21, 2022 and submitted 3 years, 3 months ago

Information

Owner

david*

Repository

Djblets

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description*

With Djblets 3.x using only Django 3.2+, we no longer need to deal with
old-style middleware or the MIDDLEWARE_CLASSES setting. This change
updates things to always use the new style.

Testing Done

Ran unit tests.

Commits

Summary	ID
Change middleware to always be new-style. With Djblets 3.x using only Django 3.2+, we no longer need to deal with old-style middleware or the MIDDLEWARE_CLASSES setting. This change updates things to always use the new style. Testing Done: Ran unit tests.	ea7313b1e56df9c3bd332bd1f1388980025b6782

Issues

Description	From	Last Updated
E501 line too long (82 > 79 characters)	reviewbot	3 years, 3 months ago
Might as well make this one statement now.	chipx86	3 years, 3 months ago
Type/description needs to be indented.	chipx86	3 years, 3 months ago
This can be: middleware = list(reversed(self._middleware_classes))	chipx86	3 years, 3 months ago
Summary should be on the """ line.	chipx86	3 years, 3 months ago
No need for parens here.	chipx86	3 years, 3 months ago
There are no open issues

flake8 failed.

JSHint passed.

flake8

djblets/extensions/middleware.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (82 > 79 characters)
```

Commits:

	Summary	ID
	Change middleware to always be new-style. With Djblets 3.x using only Django 3.2+, we no longer need to deal with old-style middleware or the MIDDLEWARE_CLASSES setting. This change updates things to always use the new style. Testing Done: Ran unit tests.	439be6ca76713884a6d08f68b94c0a82e830ca49
	Change middleware to always be new-style. With Djblets 3.x using only Django 3.2+, we no longer need to deal with old-style middleware or the MIDDLEWARE_CLASSES setting. This change updates things to always use the new style. Testing Done: Ran unit tests.	41c445ffdffd4513829e9511eb48046f9547f142

Diff:

Revision 2 (+232 -652)

Show changes

	djblets/extensions/extension.py
	djblets/extensions/manager.py
	djblets/extensions/middleware.py
	djblets/extensions/tests/test_middleware.py
	djblets/integrations/manager.py
	djblets/integrations/tests/test_manager.py
	djblets/integrations/tests/testcases.py
	docs/djblets/guides/integrations/supporting-integrations.rst
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

djblets/extensions/extension.py (Diff revision 2)

The issue has been resolved. Show all issues

Might as well make this one statement now.

djblets/extensions/middleware.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Type/description needs to be indented.
```

djblets/extensions/middleware.py (Diff revision 2)

The issue has been resolved. Show all issues

This can be:

middleware = list(reversed(self._middleware_classes))

djblets/extensions/middleware.py (Diff revision 2)

Out of curiosity, why not just keep this? Seems it was useful for keeping the other functions simple.

david 3 years, 3 months ago

It could still be used for process_view and process_exception, but process_template_response actually has different semantics (so our use of this method was incorrect before). Given that it would only be used for two things, the crazy abstraction involved with this just felt like being fancy and complex without much benefit.

djblets/extensions/middleware.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Summary should be on the """ line.
```
djblets/integrations/manager.py (Diff revision 2)
The issue has been resolved. Show all issues
```
No need for parens here.
```

Commits:

	Summary	ID
	Change middleware to always be new-style. With Djblets 3.x using only Django 3.2+, we no longer need to deal with old-style middleware or the MIDDLEWARE_CLASSES setting. This change updates things to always use the new style. Testing Done: Ran unit tests.	41c445ffdffd4513829e9511eb48046f9547f142
	Change middleware to always be new-style. With Djblets 3.x using only Django 3.2+, we no longer need to deal with old-style middleware or the MIDDLEWARE_CLASSES setting. This change updates things to always use the new style. Testing Done: Ran unit tests.	ea7313b1e56df9c3bd332bd1f1388980025b6782

Diff:

Revision 3 (+228 -654)

Show changes

	djblets/extensions/extension.py
	djblets/extensions/manager.py
	djblets/extensions/middleware.py
	djblets/extensions/tests/test_middleware.py
	djblets/integrations/manager.py
	djblets/integrations/tests/test_manager.py
	djblets/integrations/tests/testcases.py
	docs/djblets/guides/integrations/supporting-integrations.rst
	1 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.x (eed78df)