• 
      

    Add better version output and remove warnings in rbssh.

    Review Request #11948 — Created Jan. 21, 2022 and submitted

    Information

    Review Board
    release-4.0.x

    Reviewers

    This makes a couple of key changes to help diagnose issues in rbssh.

    --version now shows the Python version and the Review Board package
    location, to help ensure that the right version is being run.

    Warnings are now disabled at the top of the module, before we import
    anything that may warn. This helps avoid some bad output that can occur,
    depending on versions of packages and Python, particularly with
    Cryptography.

    Verified that this got rid of warnings that messed up test output.

    Verified that --version showed the correct information.

    Summary ID
    Add better version output and remove warnings in rbssh.
    This makes a couple of key changes to help diagnose issues in rbssh. `--version` now shows the Python version and the Review Board package location, to help ensure that the right version is being run. Warnings are now disabled at the top of the module, before we import anything that may warn. This helps avoid some bad output that can occur, depending on versions of packages and Python, particularly with Cryptography.
    4f9566c6ce200e02b9bdddbe02aae30865c5d0e2
    Description From Last Updated

    E402 module level import not at top of file

    reviewbotreviewbot
    Checks run (1 failed, 1 succeeded)
    flake8 failed.
    JSHint passed.

    flake8

    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (440f069)