Summary

Don't import collection ABCs unless we know we need to.

Review Request #11943 — Created Jan. 20, 2022 and submitted Feb. 3, 2022, 10:26 p.m.

Information

Owner

david

Repository

Djblets

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

I had made the backport for collection ABCs work conditionally on

whether we could import correctly, but that ends up raising a warning.

This change updates it so we base it on Python version instead.
It's likely this can actually go away entirely, but that will come later

once we've settled all the dependencies.

Testing Done

Ran unit tests.

Commits

Summary	ID
Don't import collection ABCs unless we know we need to. I had made the backport for collection ABCs work conditionally on whether we could import correctly, but that ends up raising a warning. This change updates it so we base it on Python version instead. It's likely this can actually go away entirely, but that will come later once we've settled all the dependencies. Testing Done: Ran unit tests.	841273473fd5d6df7ee2ae96bf94043d59c7aad7

Summary

Don't import collection ABCs unless we know we need to.

I had made the backport for collection ABCs work conditionally on whether we could import correctly, but that ends up raising a warning. This change updates it so we base it on Python version instead. It's likely this can actually go away entirely, but that will come later once we've settled all the dependencies. Testing Done: Ran unit tests.

841273473fd5d6df7ee2ae96bf94043d59c7aad7

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.x (8cac1c5)