flake8
passed.
JSHint
passed.
Review Request #11926 — Created Jan. 11, 2022 and submitted
disable_extension()made an assumption that it should always send an
extension_disabled()signal, and that it always had anextension
object to pass in.If the extension being disabled was never enabled but had a load error,
this assumption would break. This is a pretty obscure case, but one that
was hit with some test work.We now set
extensiontoNonein this case, and only emit the signal
if notNone.
Unit tests pass.
Verified this fixed the issue I was hitting in upcoming test changes.
| Summary | ID |
|---|---|
| e42614beb6729ff6808f5aa7096c3dc300f0fa3a |