• 
      

    Explicitly order keyword arguments in SpyCall.__repr__.

    Review Request #11913 — Created Jan. 9, 2022 and submitted

    Information

    kgb
    master

    Reviewers

    kgb

    SpyCall.__repr__ embedded its kwargs dictionary in the resulting
    string, but this led to random comparison problems in unit tests on
    Python 2.7 and earlier 3.x.

    This problem was already solved in the unit test assertion helpers. The
    ordering function has now been moved into kgb.utils and is called in
    SpyCall.__repr__.

    Unit tests pass on all supported versions of Python.

    Summary ID
    Explicitly order keyword arguments in SpyCall.__repr__.
    `SpyCall.__repr__` embedded its `kwargs` dictionary in the resulting string, but this led to random comparison problems in unit tests on Python 2.7 and earlier 3.x. This problem was already solved in the unit test assertion helpers. The ordering function has now been moved into `kgb.utils` and is called in `SpyCall.__repr__`.
    754142d33cfd7802f7eea584284f4d0b254b9727
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (c663022)