Summary

Custom Admin Emoji Panel (Djblets)

Review Request #11884 — Created Nov. 27, 2021 and discarded Dec. 3, 2021, 10:57 p.m.

Information

Owner

mxwang

Repository

Djblets

Branch

release-2.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

Adds a page to the admint panel which allows an admin to upload a custom emoji by uploading a name, shortcode, description, and image. These fields are editable whenever the user re-vists the page. The emoji data is loaded from, and saved into SiteConfiguration, while the image data is loaded from and saved to DefaultStorage.

Further work that needs to be done: * Enforcing mandatory fields that user must fill out before clicking "Save", so as to not raise an error. * Adding labels to the form fields, and removing the extra "name" field at the very top of the form. * Rendering a preview of the emoji when loading the page (through get_context() in EmojiFileUpload).

Testing Done

Commits

Summary	ID	Author
ListEditDictionaryField Patch from Michelle Aubin.	2feb2a1b838640fd4496e505f7877ea5ebafbf72	mxiuwang
[WIP] Adding custom emojis in admin emoji dashboard.	1f16add484e311fa95e175dc2310b48efaab08ba	mxiuwang
[WIP] rendering images.	7cc3931eab59f1db877bba4fe4b27d34bf7fa562	mxiuwang
[WIP] Render images.	ad573006dac8d287f15765c2807432943beb0c94	mxiuwang
Add docstring, code cleanup.	551239428bb72dbfa77d8921948c04ab12c184c2	mxiuwang

Issues

Description	From	Last Updated
E231 missing whitespace after ','	reviewbot	Nov. 28, 2021, 8:44 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 28, 2021, 8:44 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 28, 2021, 8:44 p.m.
E501 line too long (141 > 79 characters)	reviewbot	Nov. 28, 2021, 8:44 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 28, 2021, 8:44 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 28, 2021, 8:44 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 28, 2021, 8:44 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 28, 2021, 8:44 p.m.
E501 line too long (83 > 79 characters)	reviewbot	Nov. 28, 2021, 8:44 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 28, 2021, 8:44 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 28, 2021, 8:44 p.m.
E501 line too long (96 > 79 characters)	reviewbot	Nov. 28, 2021, 8:44 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 28, 2021, 8:44 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 28, 2021, 8:44 p.m.
E501 line too long (100 > 79 characters)	reviewbot	Nov. 28, 2021, 8:44 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 28, 2021, 8:44 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 28, 2021, 8:44 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 28, 2021, 8:44 p.m.
E501 line too long (87 > 79 characters)	reviewbot	Nov. 28, 2021, 8:44 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 28, 2021, 8:44 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 28, 2021, 8:44 p.m.
E501 line too long (199 > 79 characters)	reviewbot	Nov. 28, 2021, 8:44 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 28, 2021, 8:44 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 28, 2021, 8:44 p.m.
E501 line too long (87 > 79 characters)	reviewbot	Nov. 28, 2021, 8:44 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 28, 2021, 8:44 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 28, 2021, 8:44 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 28, 2021, 8:44 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 28, 2021, 8:44 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 28, 2021, 8:44 p.m.
Col: 87 Missing semicolon.	reviewbot	Nov. 28, 2021, 8:44 p.m.
Col: 62 Missing semicolon.	reviewbot	Nov. 28, 2021, 8:44 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:27 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:27 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:27 a.m.
E501 line too long (141 > 79 characters)	reviewbot	Dec. 3, 2021, 10:27 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:27 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:27 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:27 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:27 a.m.
E501 line too long (83 > 79 characters)	reviewbot	Dec. 3, 2021, 10:27 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:27 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:27 a.m.
E501 line too long (96 > 79 characters)	reviewbot	Dec. 3, 2021, 10:27 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:27 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:27 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:27 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:27 a.m.
E501 line too long (100 > 79 characters)	reviewbot	Dec. 3, 2021, 10:27 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:27 a.m.
E501 line too long (87 > 79 characters)	reviewbot	Dec. 3, 2021, 10:27 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:27 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:27 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:27 a.m.
E501 line too long (199 > 79 characters)	reviewbot	Dec. 3, 2021, 10:27 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:27 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:27 a.m.
E501 line too long (95 > 79 characters)	reviewbot	Dec. 3, 2021, 10:27 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:27 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:27 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:27 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:27 a.m.
Col: 87 Missing semicolon.	reviewbot	Dec. 3, 2021, 10:27 a.m.
Col: 62 Missing semicolon.	reviewbot	Dec. 3, 2021, 10:27 a.m.
W293 blank line contains whitespace	reviewbot	Dec. 3, 2021, 10:27 a.m.
W293 blank line contains whitespace	reviewbot	Dec. 3, 2021, 10:27 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:27 a.m.
W293 blank line contains whitespace	reviewbot	Dec. 3, 2021, 10:27 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:27 a.m.
F401 'django.core.files.storage.DefaultStorage' imported but unused	reviewbot	Dec. 3, 2021, 10:27 a.m.
F401 'django.utils.html.format_html_join' imported but unused	reviewbot	Dec. 3, 2021, 10:27 a.m.
F401 'django.utils.html.format_html' imported but unused	reviewbot	Dec. 3, 2021, 10:27 a.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 3, 2021, 10:27 a.m.
W293 blank line contains whitespace	reviewbot	Dec. 3, 2021, 10:27 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:27 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:27 a.m.
W292 no newline at end of file	reviewbot	Dec. 3, 2021, 10:27 a.m.
Col: 87 Missing semicolon.	reviewbot	Dec. 3, 2021, 10:27 a.m.
Col: 62 Missing semicolon.	reviewbot	Dec. 3, 2021, 10:27 a.m.

flake8 failed.

JSHint failed.

flake8

```
Warning: Showing 30 of 37 failures.
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (141 > 79 characters)
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (83 > 79 characters)
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (96 > 79 characters)
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (100 > 79 characters)
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (87 > 79 characters)
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (199 > 79 characters)
```
djblets/avatars/services/file_upload.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/fields.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
djblets/forms/fields.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (87 > 79 characters)
```
djblets/forms/fields.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/fields.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/fields.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/fields.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
djblets/forms/fields.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```

JSHint

djblets/static/djblets/js/forms/views/listEditView.es6.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 87
 Missing semicolon.
```
djblets/static/djblets/js/forms/views/listEditView.es6.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 62
 Missing semicolon.
```

Commits:

Summary	ID	Author
ListEditDictionaryField Patch from Michelle Aubin.	2feb2a1b838640fd4496e505f7877ea5ebafbf72	mxiuwang
[WIP] Adding custom emojis in admin emoji dashboard.	1f16add484e311fa95e175dc2310b48efaab08ba	mxiuwang
ListEditDictionaryField Patch from Michelle Aubin.	2feb2a1b838640fd4496e505f7877ea5ebafbf72	mxiuwang
[WIP] Adding custom emojis in admin emoji dashboard.	1f16add484e311fa95e175dc2310b48efaab08ba	mxiuwang
[WIP] rendering images.	7cc3931eab59f1db877bba4fe4b27d34bf7fa562	mxiuwang

Diff:

Revision 2 (+950 -214)

Show changes

	djblets/avatars/services/file_upload.py
	djblets/forms/fields.py
	djblets/forms/widgets.py
	djblets/forms/forms/key_value_form.py
	djblets/forms/templates/djblets_forms/list_edit_widget.html
	djblets/forms/tests/test_list_edit_dictionary_field.py
	djblets/forms/tests/test_list_edit_field.py
	djblets/static/djblets/js/forms/views/listEditView.es6.js

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

```
Warning: Showing 30 of 43 failures.
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (141 > 79 characters)
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (83 > 79 characters)
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (96 > 79 characters)
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (100 > 79 characters)
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (87 > 79 characters)
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
djblets/avatars/services/file_upload.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (199 > 79 characters)
```
djblets/forms/fields.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/fields.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
djblets/forms/fields.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (95 > 79 characters)
```
djblets/forms/fields.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/fields.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/fields.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
djblets/forms/fields.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```

JSHint

djblets/static/djblets/js/forms/views/listEditView.es6.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 87
 Missing semicolon.
```
djblets/static/djblets/js/forms/views/listEditView.es6.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 62
 Missing semicolon.
```

Summary:

ListEditDictionaryField Patch from Michelle Aubin.

Custom Admin Emoji Panel (Djblets)

Description:

~		[WIP] Adding custom emojis in admin emoji dashboard.
	~	Adds a page to the admint panel which allows an admin to upload a custom emoji by uploading a name, shortcode, description, and image. These fields are editable whenever the user re-vists the page. The emoji data is loaded from, and saved into SiteConfiguration, while the image data is loaded from and saved to DefaultStorage.
	+
	+
	+
	+	Further work that needs to be done:
	+	* Enforcing mandatory fields that user must fill out before clicking "Save", so as to not raise an error.
	+	* Adding labels to the form fields, and removing the extra "name" field at the very top of the form.
	+	* Rendering a preview of the emoji when loading the page (through get_context() in EmojiFileUpload).

Commits:

Summary	ID	Author
ListEditDictionaryField Patch from Michelle Aubin.	2feb2a1b838640fd4496e505f7877ea5ebafbf72	mxiuwang
[WIP] Adding custom emojis in admin emoji dashboard.	1f16add484e311fa95e175dc2310b48efaab08ba	mxiuwang
[WIP] rendering images.	7cc3931eab59f1db877bba4fe4b27d34bf7fa562	mxiuwang
ListEditDictionaryField Patch from Michelle Aubin.	2feb2a1b838640fd4496e505f7877ea5ebafbf72	mxiuwang
[WIP] Adding custom emojis in admin emoji dashboard.	1f16add484e311fa95e175dc2310b48efaab08ba	mxiuwang
[WIP] rendering images.	7cc3931eab59f1db877bba4fe4b27d34bf7fa562	mxiuwang
[WIP] Render images.	ad573006dac8d287f15765c2807432943beb0c94	mxiuwang
Add docstring, code cleanup.	551239428bb72dbfa77d8921948c04ab12c184c2	mxiuwang

Diff:

Revision 3 (+1012 -286)

Show changes

	djblets/avatars/services/base.py
	djblets/avatars/services/file_upload.py
	djblets/forms/fields.py
	djblets/forms/widgets.py
	djblets/forms/templates/djblets_forms/emoji_file_input.html
	djblets/forms/templates/djblets_forms/list_edit_widget.html
	djblets/forms/tests/test_list_edit_dictionary_field.py
	djblets/forms/tests/test_list_edit_field.py
	1 more

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

djblets/avatars/services/base.py (Diff revision 3)
An issue was opened. Show all issues
```
W293 blank line contains whitespace
```
djblets/avatars/services/file_upload.py (Diff revision 3)
An issue was opened. Show all issues
```
W293 blank line contains whitespace
```
djblets/forms/fields.py (Diff revision 3)
An issue was opened. Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/fields.py (Diff revision 3)
An issue was opened. Show all issues
```
W293 blank line contains whitespace
```
djblets/forms/fields.py (Diff revision 3)
An issue was opened. Show all issues
```
W291 trailing whitespace
```
djblets/forms/widgets.py (Diff revision 3)
An issue was opened. Show all issues
```
F401 'django.core.files.storage.DefaultStorage' imported but unused
```
djblets/forms/widgets.py (Diff revision 3)
An issue was opened. Show all issues
```
F401 'django.utils.html.format_html_join' imported but unused
```
djblets/forms/widgets.py (Diff revision 3)
An issue was opened. Show all issues
```
F401 'django.utils.html.format_html' imported but unused
```
djblets/forms/widgets.py (Diff revision 3)
An issue was opened. Show all issues
```
E302 expected 2 blank lines, found 1
```
djblets/forms/widgets.py (Diff revision 3)
An issue was opened. Show all issues
```
W293 blank line contains whitespace
```
djblets/forms/widgets.py (Diff revision 3)
An issue was opened. Show all issues
```
W291 trailing whitespace
```
djblets/forms/widgets.py (Diff revision 3)
An issue was opened. Show all issues
```
W291 trailing whitespace
```
djblets/forms/widgets.py (Diff revision 3)
An issue was opened. Show all issues
```
W292 no newline at end of file
```

JSHint

djblets/static/djblets/js/forms/views/listEditView.es6.js (Diff revision 3)
An issue was opened. Show all issues
```
Col: 87
 Missing semicolon.
```
djblets/static/djblets/js/forms/views/listEditView.es6.js (Diff revision 3)
An issue was opened. Show all issues
```
Col: 62
 Missing semicolon.
```

Status:: Discarded

djblets/forms/fields.py (Diff revision 1)

djblets/forms/fields.py (Diff revision 1)

djblets/forms/fields.py (Diff revision 1)

djblets/forms/fields.py (Diff revision 1)