Summary

WIP_Oct21

Review Request #11877 — Created Nov. 18, 2021 and discarded Nov. 21, 2021, 9:15 p.m.

Information

Owner

matthewgoodman13

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

changes


changes

Testing Done

Issues

Description	From	Last Updated
E501 line too long (80 > 79 characters)	reviewbot	Nov. 18, 2021, 9:04 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2021, 9:04 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 18, 2021, 9:04 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 18, 2021, 9:04 p.m.
E501 line too long (115 > 79 characters)	reviewbot	Nov. 18, 2021, 9:04 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Nov. 18, 2021, 9:04 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Nov. 18, 2021, 9:04 p.m.
E501 line too long (87 > 79 characters)	reviewbot	Nov. 18, 2021, 9:04 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Nov. 18, 2021, 9:04 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Nov. 18, 2021, 9:04 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 11 Missing semicolon.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 10 Missing semicolon.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 33 Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (categories, category)	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 11 Missing semicolon.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 11 Missing semicolon.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 46 Missing semicolon.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 11 Missing semicolon.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 37 ['emoji_url'] is better written in dot notation.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 53 Expected '!==' and instead saw '!='.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 42 ['unicode'] is better written in dot notation.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 56 Expected '!==' and instead saw '!='.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 106 ['unicode'] is better written in dot notation.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 111 Missing semicolon.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 97 ['name'] is better written in dot notation.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 43 ['category'] is better written in dot notation.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 42 ['category'] is better written in dot notation.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 102 ['category'] is better written in dot notation.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 65 ['unicode'] is better written in dot notation.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 33 Missing semicolon.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 40 Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (key)	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 59 Missing semicolon.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 19 Missing semicolon.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 52 Missing semicolon.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 35 Missing semicolon.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 51 Missing semicolon.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 100 Missing semicolon.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 124 Missing semicolon.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 41 Missing semicolon.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 88 Missing semicolon.	reviewbot	Nov. 18, 2021, 9:04 p.m.
Col: 118 Missing semicolon.	reviewbot	Nov. 18, 2021, 9:04 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Nov. 18, 2021, 9:04 p.m.
E303 too many blank lines (2)	reviewbot	Nov. 18, 2021, 9:04 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 18, 2021, 9:04 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 18, 2021, 9:04 p.m.
E501 line too long (97 > 79 characters)	reviewbot	Nov. 18, 2021, 9:04 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 18, 2021, 9:04 p.m.
E201 whitespace after '{'	reviewbot	Nov. 18, 2021, 9:04 p.m.
E202 whitespace before '}'	reviewbot	Nov. 18, 2021, 9:04 p.m.
E305 expected 2 blank lines after class or function definition, found 1	reviewbot	Nov. 18, 2021, 9:04 p.m.
W292 no newline at end of file	reviewbot	Nov. 18, 2021, 9:04 p.m.
E501 line too long (32480 > 79 characters)	reviewbot	Nov. 18, 2021, 9:04 p.m.
W292 no newline at end of file	reviewbot	Nov. 18, 2021, 9:04 p.m.

flake8 failed.

JSHint failed.

flake8

reviewboard/reviews/markdown_utils.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/reviews/markdown_utils.py (Diff revision 1)
An issue was opened. Show all issues
```
W291 trailing whitespace
```
reviewboard/reviews/markdown_utils.py (Diff revision 1)
An issue was opened. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/reviews/markdown_utils.py (Diff revision 1)
An issue was opened. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/reviews/markdown_utils.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (115 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (87 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (81 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (81 > 79 characters)
```
reviewboard/webapi/resources/emoji.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/emoji.py (Diff revision 1)
An issue was opened. Show all issues
```
E303 too many blank lines (2)
```
reviewboard/webapi/resources/emoji.py (Diff revision 1)
An issue was opened. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/webapi/resources/emoji.py (Diff revision 1)
An issue was opened. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/webapi/resources/emoji.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (97 > 79 characters)
```
reviewboard/webapi/resources/emoji.py (Diff revision 1)
An issue was opened. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/webapi/resources/emoji.py (Diff revision 1)
An issue was opened. Show all issues
```
E201 whitespace after '{'
```
reviewboard/webapi/resources/emoji.py (Diff revision 1)
An issue was opened. Show all issues
```
E202 whitespace before '}'
```
reviewboard/webapi/resources/emoji.py (Diff revision 1)
An issue was opened. Show all issues
```
E305 expected 2 blank lines after class or function definition, found 1
```
reviewboard/webapi/resources/emoji.py (Diff revision 1)
An issue was opened. Show all issues
```
W292 no newline at end of file
```
reviewboard/webapi/resources/emoji_sort_order.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (32480 > 79 characters)
```
reviewboard/webapi/resources/emoji_sort_order.py (Diff revision 1)
An issue was opened. Show all issues
```
W292 no newline at end of file
```

JSHint

```
Warning: Showing 30 of 41 failures.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 11
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 10
 Missing semicolon.
```

reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)

An issue was opened. Show all issues

Col: 33
 Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (categories, category)

reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 11
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 11
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 46
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 11
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 37
 ['emoji_url'] is better written in dot notation.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 53
 Expected '!==' and instead saw '!='.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 42
 ['unicode'] is better written in dot notation.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 56
 Expected '!==' and instead saw '!='.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 106
 ['unicode'] is better written in dot notation.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 111
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 97
 ['name'] is better written in dot notation.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 43
 ['category'] is better written in dot notation.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 42
 ['category'] is better written in dot notation.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 102
 ['category'] is better written in dot notation.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 65
 ['unicode'] is better written in dot notation.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 33
 Missing semicolon.
```

reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)

An issue was opened. Show all issues

Col: 40
 Functions declared within loops referencing an outer scoped variable may lead to confusing semantics. (key)

reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 59
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 19
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 52
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 35
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 51
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 100
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 124
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 41
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 88
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 118
 Missing semicolon.
```

Status:: Discarded