Summary

[WIP | Emoji UI Picker Project] Emoji Picker icon in markdown text area, opens UI, and abilty to click on an emoji to copy-paste shortcode into markdown text field

Review Request #11870 — Created Nov. 6, 2021 and discarded Nov. 21, 2021, 10:15 p.m.

Information

Owner

matthewgoodman13

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

[WIP | Emoji UI Picker Project][Demo 2] Emoji Picker icon in markdown text area, opens UI, and abilty to click on an emoji to copy-paste shortcode into markdown text field
Code cleaning in progress.

Testing Done

Issues

Description	From	Last Updated
E501 line too long (80 > 79 characters)	reviewbot	Nov. 6, 2021, 12:17 p.m.
W291 trailing whitespace	reviewbot	Nov. 6, 2021, 12:17 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 6, 2021, 12:17 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 6, 2021, 12:17 p.m.
E501 line too long (115 > 79 characters)	reviewbot	Nov. 6, 2021, 12:17 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Nov. 6, 2021, 12:17 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Nov. 6, 2021, 12:17 p.m.
E501 line too long (87 > 79 characters)	reviewbot	Nov. 6, 2021, 12:17 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Nov. 6, 2021, 12:17 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Nov. 6, 2021, 12:17 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Nov. 6, 2021, 12:17 p.m.
Col: 67 Missing semicolon.	reviewbot	Nov. 6, 2021, 12:17 p.m.
Col: 57 Missing semicolon.	reviewbot	Nov. 6, 2021, 12:17 p.m.
Col: 46 Missing semicolon.	reviewbot	Nov. 6, 2021, 12:17 p.m.
Col: 81 Missing semicolon.	reviewbot	Nov. 6, 2021, 12:17 p.m.
Col: 11 Missing semicolon.	reviewbot	Nov. 6, 2021, 12:17 p.m.
Col: 11 Missing semicolon.	reviewbot	Nov. 6, 2021, 12:17 p.m.
Col: 37 Missing semicolon.	reviewbot	Nov. 6, 2021, 12:17 p.m.
Col: 40 Missing semicolon.	reviewbot	Nov. 6, 2021, 12:17 p.m.
Col: 28 Missing semicolon.	reviewbot	Nov. 6, 2021, 12:17 p.m.

flake8 failed.

JSHint failed.

flake8

reviewboard/reviews/markdown_utils.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/reviews/markdown_utils.py (Diff revision 1)
An issue was opened. Show all issues
```
W291 trailing whitespace
```
reviewboard/reviews/markdown_utils.py (Diff revision 1)
An issue was opened. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/reviews/markdown_utils.py (Diff revision 1)
An issue was opened. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/reviews/markdown_utils.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (115 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (87 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (81 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 1)
An issue was opened. Show all issues
```
E501 line too long (81 > 79 characters)
```

JSHint

reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 67
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 57
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 46
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 81
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 11
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 11
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 37
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/emojiPickerView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 40
 Missing semicolon.
```
reviewboard/static/rb/js/ui/views/inlineEditorView.es6.js (Diff revision 1)
An issue was opened. Show all issues
```
Col: 28
 Missing semicolon.
```

Status:: Discarded